Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make "Are you sure you want to restart the kernel?" warning optional #7694

Merged
merged 2 commits into from
Aug 17, 2018

Conversation

estraiton
Copy link

@estraiton estraiton commented Aug 15, 2018

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP8 for code style
  • Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Wrote at least one-line docstrings for any new functions
  • Added at least one unit test covering the changes, if at all possible
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed
  • Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes

There is now an option to not show the dialogue box when restarting the ipython kernel. This will be less annoying for users who may wish to do this often.

spyder_ui_change

Issue(s) Resolved

Fixes #7561

@pep8speaks
Copy link

pep8speaks commented Aug 15, 2018

Hello @estraiton! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 15, 2018 at 10:02 Hours UTC

@estraiton estraiton changed the base branch from master to 3.x August 15, 2018 09:38
@ccordoba12 ccordoba12 changed the title Make 'Are you sure you want to restart the kernel?' warning optional PR: Make 'Are you sure you want to restart the kernel?' warning optional Aug 15, 2018
@ccordoba12 ccordoba12 added this to the v3.3.2 milestone Aug 15, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice @estraiton!! Great job for your first-time contribution to Spyder!

Thanks a lot for it!

@ccordoba12 ccordoba12 changed the title PR: Make 'Are you sure you want to restart the kernel?' warning optional PR: Make "Are you sure you want to restart the kernel?" warning optional Aug 17, 2018
@ccordoba12 ccordoba12 merged commit a44635a into spyder-ide:3.x Aug 17, 2018
ccordoba12 added a commit that referenced this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants