PR: Update conda install command for spyder-kernels 1.x #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Aug 2, 2018
CONTRIBUTING.md
Outdated
| @@ -108,7 +108,7 @@ corresponding `1.x` version of `spyder-kernels`. | |||
| This can be done via two methods: installing the correct version via `conda`: | |||
|
|
|||
| ```bash | |||
| conda install spyder-kernels=1 | |||
| conda install -c conda-forge spyder-kernels=1.* | |||
There was a problem hiding this comment.
As I mentioned in the spyder-docs PR, please change this to
conda install -c spyder-ide spyder-kernels=1.*
ccordoba12
reviewed
Aug 2, 2018
README.md
Outdated
| so to run the `master` branch (Spyder 4) you need to additionally execute: | ||
|
|
||
| ```bash | ||
| conda install spyder-kernels=1.* | ||
| conda install -c conda-forge spyder-kernels=1.* |
There was a problem hiding this comment.
conda-forge -> spyder-kernels
|
Again, let's wait until we move the spyder-kernels packages to our channel. |
ccordoba12
approved these changes
Aug 2, 2018
ccordoba12
approved these changes
Aug 3, 2018
ccordoba12
added a commit
that referenced
this pull request
Aug 3, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
modified the
spyder/defaultsdirectory, or added new icons/assetsDescription of Changes
Per the discussion in spyder-ide/spyder-docs#69 , this PR corrects the install command for
spyder-kernels1.x to useconda-forge, since it isn't available for all platforms on the maindefaultschannel. Also, fixes a few minor but silly typos in the lines near it.