Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Move all kernel code to an external package called spyder-kernels #7306

Merged
merged 31 commits into from
Jun 23, 2018
Merged

PR: Move all kernel code to an external package called spyder-kernels #7306

merged 31 commits into from
Jun 23, 2018

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jun 18, 2018 •
edited
Loading

Fixes #6469
Fixes #6297

TODO

  • Add spyder-kernels to our CIs
  • Add spyder-kernels to conda-forge
  • Add spyder-kernels to setup.py with <1.0
  • Change this message to check for spyder-kernels and its right version (instead of ipykernel and cloudpickle).

@dalthviz, please help me to finish this one.

@ccordoba12 ccordoba12 added this to the v3.3 milestone Jun 18, 2018
@ccordoba12
Copy link
Member Author

ccordoba12 commented Jun 18, 2018 •
edited
Loading

This is the new package:

https://github.com/spyder-ide/spyder-kernels
https://pypi.org/project/spyder-kernels/

@ccordoba12 ccordoba12 mentioned this pull request Jun 18, 2018
Closed
@pep8speaks
Copy link

pep8speaks commented Jun 20, 2018 •
edited
Loading

Hello @ccordoba12! Thanks for updating the PR.

Line 330:80: E501 line too long (81 > 79 characters)

Comment last updated on June 23, 2018 at 23:34 Hours UTC

@ccordoba12
Copy link
Member Author

@dalthviz, I have a solution for our failing tests. Please don't add more commits here.

ccordoba12 added 10 commits June 21, 2018 14:06
@ccordoba12
IPython console: Simplify how we handle %edit magic petitions
a683dd7
@ccordoba12
Testing: Fix test_single_instance_and_edit_magic
1141da4
@ccordoba12
Variable Explorer: Move PICKLE_PROTOCOL to config.base
604ccb0
@ccordoba12
IPython console: Send breakpoints from Spyder to the kernel
a15abb8 
Before we were reading them in the kernel, using Spyder's config system
@ccordoba12
IPython console: Handle a new Spyder message from the kernel called s…
76582b6 
…et_breakpoints

This necessary because the kernel needs to ask Spyder for its
breakpoints as soon as it enters debugging.
@ccordoba12
Testing: Skip a couple of tests that are failing locally
e0c6ace
@ccordoba12
IPython console: Send serialized breakpoints to the kernel inside a list
b6c15ed 
This way they can be sent in Python 2
@ccordoba12
IPython console: Check for spyder_kernels<1.0 in external interpreters
1c55847
@ccordoba12
Testing: Pin spyder-kernels to 0.* in all our CIs
00eb14a
@ccordoba12
IPython console: Fix grammar in spyder_kernels error message
391abde
@CAM-Gerlach CAM-Gerlach mentioned this pull request Jun 22, 2018
Closed
@ccordoba12 ccordoba12 mentioned this pull request Jun 23, 2018
Merged
9 tasks
@ccordoba12
Copy link
Member Author

This is ready!

@ccordoba12 ccordoba12 merged commit 3e3e70e into spyder-ide:3.x Jun 23, 2018
@ccordoba12 ccordoba12 deleted the move-kernel-out branch June 23, 2018 23:53
ccordoba12 added a commit that referenced this pull request Jun 24, 2018
@ccordoba12
Merge from 3.x: PR #7306
2c917bf 
Fixes #6469
Fixes #6297
@ccordoba12 ccordoba12 mentioned this pull request Jun 25, 2018
Merged
@CAM-Gerlach CAM-Gerlach mentioned this pull request Jun 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dalthviz dalthviz

Labels
None yet
Projects
None yet
Milestone
v3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ccordoba12 @pep8speaks @dalthviz