Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Handle AttributeError when setting color scheme in the IPython Console. #7164

Merged
merged 1 commit into from
May 21, 2018
Merged

PR: Handle AttributeError when setting color scheme in the IPython Console. #7164

merged 1 commit into from
May 21, 2018

Conversation

dalthviz
Copy link
Member

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP8 for code style
  • Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Wrote at least one-line docstrings for any new functions
  • Added at least one unit test covering the changes, if at all possible
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed
  • Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes

Add try catch to handle AttributeError when setting color scheme in the IPython Console

Issue(s) Resolved

Fixes #6996

@dalthviz dalthviz added this to the v3.3 milestone May 21, 2018
@dalthviz dalthviz self-assigned this May 21, 2018
@dalthviz dalthviz requested a review from ccordoba12 May 21, 2018 17:44
ccordoba12
ccordoba12 approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit cb33f48 into spyder-ide:3.x May 21, 2018
ccordoba12 added a commit that referenced this pull request May 21, 2018
@ccordoba12
Merge from 3.x: PR #7164
f9b32a0 
Fixes #6996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
component:IPython Console type:Bug
Projects
None yet
Milestone
v3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@dalthviz @ccordoba12