PR: Load libGL using low-level function without requiring pyopengl #7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading libGL at the very start fixes a segmentation fault on some Linux systems. This uses a low-level function from cdll to load libGL instead of requiring and importing pyopengl which implicitly loads libGL )I guess). Thus, we also drop the pyopengl requirement.
|
An alternative is to wait until this is fixed in anaconda but it's not clear to me how long that takes. |
|
I assume that the Travis failure (a version conflict involving parso and jedi) has nothing to do with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6968.
Loading libGL at the very start fixes a segmentation fault on some Linux systems (including mine!). This uses a low-level function from cdll to load libGL instead of requiring and importing pyopengl which implicitly loads libGL (I guess). Thus, we also drop the pyopengl requirement.
See discussion at ContinuumIO/anaconda-issues#9199 (where @ccordoba12 approved this approach) and #3226.