Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add authentication dialog to submit issues to Github #6707

Merged
merged 28 commits into from
Mar 28, 2018
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
de937e0
Add login dialog to submit issues to github.
dalthviz Mar 10, 2018
c8f7df1
Add validation for pytest.
dalthviz Mar 10, 2018
5faa128
Github dialog: Use Spyder conventions when importing qtpy
ccordoba12 Mar 24, 2018
a663e80
Github dialog: Add a test function to the dialog
ccordoba12 Mar 24, 2018
1f5b97a
Github Dialog: Remove ui file and create layout with code
ccordoba12 Mar 24, 2018
5d96cf8
Github dialog: Simplify header construction
ccordoba12 Mar 24, 2018
a61013e
Github dialog: Simple refactor
ccordoba12 Mar 24, 2018
c8b5528
Error dialog: Improve layout
ccordoba12 Mar 24, 2018
7ae48c2
Update with 3.x
ccordoba12 Mar 24, 2018
201dca4
Report error: Set a min number of chars for the title and use it to a…
ccordoba12 Mar 24, 2018
faae67d
Error dialog: Fix tests
ccordoba12 Mar 24, 2018
5c5ac75
Github dialog: Add token-based authentication
ccordoba12 Mar 24, 2018
2717ce6
Error dialog: Use current approach as fallback when sending to GH fails
ccordoba12 Mar 24, 2018
ba054df
Github dialog: Add for translation some strings
ccordoba12 Mar 24, 2018
4eeed28
Main window: Remove unneeded kwarg
ccordoba12 Mar 24, 2018
19f11d6
Error dialog: Make it work without being attached to the main window
ccordoba12 Mar 25, 2018
9747bc6
Github dialog: Fix an error with its backend
ccordoba12 Mar 25, 2018
0b8ac2b
Error dialog: Improve error message
ccordoba12 Mar 25, 2018
a5baebe
Github dialog: Fix token authentication
ccordoba12 Mar 25, 2018
2fce0dc
Error dialog: Add Github icon to submit button
ccordoba12 Mar 25, 2018
24cd834
Github dialog: Remove unneeded code to use GH icons
ccordoba12 Mar 25, 2018
5037ef3
Error dialog: Fix some style issues
ccordoba12 Mar 26, 2018
cee2f2e
Error dialog: Remove unneeded import
ccordoba12 Mar 26, 2018
d3dac82
Error dialog: Make some changes to several texts after review
ccordoba12 Mar 28, 2018
98a3f03
Error dialog: Set tab key focus order
ccordoba12 Mar 28, 2018
e16ef0c
Github dialog: Improve module docstrings
ccordoba12 Mar 28, 2018
239286b
Testing: Add some tests for the Github dialog
ccordoba12 Mar 28, 2018
8a68bd0
Testing: Fix docstring for the Github dialog tests
ccordoba12 Mar 28, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Github dialog: Simple refactor
  • Loading branch information
ccordoba12 committed Mar 24, 2018
commit a61013edb89cc8051a2f81a8a5c205e4d9c48730
14 changes: 7 additions & 7 deletions spyder/widgets/github/gh_login.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,21 @@ def __init__(self, parent, username):
lbl_html = QLabel(html.format(mark=mark, title=title))

# User and password
formLayout = QFormLayout()
formLayout.setContentsMargins(-1, 0, -1, -1)
form_layout = QFormLayout()
form_layout.setContentsMargins(-1, 0, -1, -1)

lbl_user = QLabel(_("Username:"))
formLayout.setWidget(0, QFormLayout.LabelRole, lbl_user)
form_layout.setWidget(0, QFormLayout.LabelRole, lbl_user)
self.le_user = QLineEdit()
self.le_user.textChanged.connect(self.update_btn_state)
formLayout.setWidget(0, QFormLayout.FieldRole, self.le_user)
form_layout.setWidget(0, QFormLayout.FieldRole, self.le_user)

lbl_password = QLabel(_("Password: "))
formLayout.setWidget(1, QFormLayout.LabelRole, lbl_password)
form_layout.setWidget(1, QFormLayout.LabelRole, lbl_password)
self.le_password = QLineEdit()
self.le_password.setEchoMode(QLineEdit.Password)
self.le_password.textChanged.connect(self.update_btn_state)
formLayout.setWidget(1, QFormLayout.FieldRole, self.le_password)
form_layout.setWidget(1, QFormLayout.FieldRole, self.le_password)

# Sign in button
self.bt_sign_in = QPushButton(_("Sign in"))
Expand All @@ -69,7 +69,7 @@ def __init__(self, parent, username):
# Main layout
layout = QVBoxLayout()
layout.addWidget(lbl_html)
layout.addLayout(formLayout)
layout.addLayout(form_layout)
layout.addWidget(self.bt_sign_in)
self.setLayout(layout)

Expand Down