Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Patch ipykernel to avoid errors when setting the Qt5 Matplotlib backend #6121

Merged
merged 4 commits into from
Jan 3, 2018

Conversation

ccordoba12
Copy link
Member

Fixes #6091.

@ccordoba12 ccordoba12 added this to the v3.2.6 milestone Jan 3, 2018
@pep8speaks
Copy link

pep8speaks commented Jan 3, 2018

Hello @ccordoba12! Thanks for updating the PR.

Line 270:1: E402 module level import not at top of file
Line 271:1: E402 module level import not at top of file
Line 273:5: E129 visually indented line with same indent as next logical line

Comment last updated on January 03, 2018 at 22:16 Hours UTC

@stonebig
Copy link
Contributor

stonebig commented Jan 3, 2018

shouldn't it be written more safely for the future ?

# f ipykernel.__version__ <= '4.7.0':
from distutils.version import LooseVersion
if LooseVersion(ipykernel.__version__) <= LooseVersion('4.7.0') and LooseVersion(IPython.__version__) >= LooseVersion('5.5.0'):

@ccordoba12
Copy link
Member Author

shouldn't it be written more safely for the future ?

Done.

@ccordoba12 ccordoba12 changed the base branch from master to 3.x January 3, 2018 22:31
@ccordoba12 ccordoba12 merged commit 1999ec3 into spyder-ide:3.x Jan 3, 2018
@ccordoba12 ccordoba12 deleted the fix-autobackend branch January 3, 2018 22:33
ccordoba12 added a commit that referenced this pull request Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants