Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add test coverage reporting with AppVeyor to Codecov #6042

Merged
merged 3 commits into from
Dec 26, 2017
Merged

PR: Add test coverage reporting with AppVeyor to Codecov #6042

merged 3 commits into from
Dec 26, 2017

Conversation

jnsebgosselin
Copy link
Member

@jnsebgosselin jnsebgosselin commented Dec 23, 2017 •
edited
Loading

@jnsebgosselin jnsebgosselin self-assigned this Dec 23, 2017
@jnsebgosselin
Copy link
Member Author

jnsebgosselin commented Dec 23, 2017 •
edited
Loading

@ccordoba12 Do you want to add a badge for codecov on the README?

codecov

ccordoba12
ccordoba12 reviewed Dec 23, 2017
View reviewed changes
.codecov.yml
require_ci_to_pass: yes

codecov:
branch: master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run this in 3.x too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So please move this PR to the 3.x branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run this in 3.x too

From my understanding, the branch option in the .yaml is used to specify which branch is displayed by default on the codecov project homepage. From codecov documentation:

"This will change the branch used on the default project dashboard"

I think that master is used by default, so I've only kept this option in the .yaml file in case we want to change it later. Do you prefer to have the 3.x instead?

So please move this PR to the 3.x branch.

You are right, I will rebase this PR to the 3.x branch.

@ccordoba12
Copy link
Member

Do you want to add a badge for codecov on the README?

Ok, no problem.

@jnsebgosselin jnsebgosselin changed the base branch from master to 3.x December 24, 2017 02:01
@jnsebgosselin
Copy link
Member Author

Thank you very much for the detailed description @CAM-Gerlach . Just to be sure I understood correctly, you are skipping some of the tests because they fail locally on your machine, even if they pass on our CI?

@CAM-Gerlach
Copy link
Member

@jnsebgosselin I think you mean to reply on #6044 :P

@jnsebgosselin
Copy link
Member Author

@CAM-Gerlach I was wondering where my answer went lol !

@ccordoba12 ccordoba12 added this to the v3.2.6 milestone Dec 26, 2017
ccordoba12
ccordoba12 approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jnsebgosselin! Good job 👍

@ccordoba12 ccordoba12 changed the title PR: Adding test coverage reporting with AppVeyor to Codecov PR: Add test coverage reporting with AppVeyor to Codecov Dec 26, 2017
@ccordoba12 ccordoba12 merged commit 1d4834d into spyder-ide:3.x Dec 26, 2017
ccordoba12 added a commit that referenced this pull request Dec 26, 2017
@ccordoba12
Merge from 3.x: PR #6042
aa41c60
@jnsebgosselin jnsebgosselin deleted the setup_codecov_appveyor branch December 29, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@jnsebgosselin jnsebgosselin

Labels
None yet
Projects
None yet
Milestone
v3.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@jnsebgosselin @ccordoba12 @CAM-Gerlach