Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Differenciate between ), }, and ] when closing brackets #6017

Merged
merged 3 commits into from
Jan 26, 2018

Conversation

impact27
Copy link
Contributor

This is related to issue #5588. Eg:
my cursor is |. if I type ']', I would expect it to not be written.
( [|]
)
But as the parenthesis is closed on the next line, this is not closed! even though my brackets are all closed.

@pep8speaks
Copy link

pep8speaks commented Dec 19, 2017

Hello @impact27! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on December 19, 2017 at 17:36 Hours UTC

@ccordoba12 ccordoba12 changed the title Differenciate between ), }, and ] PR: Differenciate between ), }, and ] Dec 21, 2017
@ccordoba12 ccordoba12 added this to the v3.2.6 milestone Dec 21, 2017
@ccordoba12
Copy link
Member

Thanks for your contribution @impact27! Any chance of adding a test for this?

@ccordoba12 ccordoba12 modified the milestones: v3.2.6, v3.2.7 Dec 30, 2017
@CAM-Gerlach
Copy link
Member

@impact27 3.2.7 is planned to be released soon; any chance of getting this done in the next few days? Thanks.

@impact27
Copy link
Contributor Author

I am not sure how to write tests and I don't really have time to figure that out in the next few days. sorry

@ccordoba12
Copy link
Member

@impact27, ok, no problem. Let's merge it to see what happens.

@ccordoba12 ccordoba12 changed the title PR: Differenciate between ), }, and ] PR: Differenciate between ), }, and ] when closing brackets Jan 26, 2018
@ccordoba12 ccordoba12 merged commit 2f50ec6 into spyder-ide:3.x Jan 26, 2018
ccordoba12 added a commit that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants