Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Several improvements to the IPython console #5878

Merged
merged 30 commits into from
Dec 10, 2017

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Dec 3, 2017

Fixes #5944
Fixes #5759
Fixes #5360

This PR seeks to fix several issues with our IPython consoles, discovered after we removed the old Python console. In particular, we want to

  • Improve kernel startup time
    • Move all imports in spyder_kernel.py to the methods that use them.
    • Stop using CONF in start_kernel.py
    • Use a local, simpler version of is_module_installed in start_kernel.py
    • Don't load Matplotlib in sitecustomize.py
  • Use a default configuration for the inline backend.
  • Show elapsed time.
  • Show button to reset kernel.
  • Check IPython version when trying to set use_jedi option.
  • Test elapsed time with external kernels.
  • Close Matplotlib windows when resetting namespace.
  • Add Remove all variables entry to the Options menu
  • Test what happens on dedicated consoles.

@ccordoba12 ccordoba12 added this to the v3.2.5 milestone Dec 3, 2017
@pep8speaks
Copy link

pep8speaks commented Dec 3, 2017

Hello @ccordoba12! Thanks for updating the PR.

Line 105:80: E501 line too long (80 > 79 characters)

Line 103:80: E501 line too long (80 > 79 characters)

Line 289:9: E722 do not use bare except'

Line 28:5: E722 do not use bare except'

Line 321:42: E128 continuation line under-indented for visual indent
Line 562:37: E261 at least two spaces before inline comment

Comment last updated on December 10, 2017 at 23:23 Hours UTC

This way there are less chances of clashes with user defined vars.
This will prevent possible crashes if a var is not found in the kernel
env (e.g. when starting a kernel without our kernel spec).
@ccordoba12 ccordoba12 merged commit 46f47e6 into spyder-ide:3.x Dec 10, 2017
@ccordoba12 ccordoba12 deleted the improve-ipyconsoles branch December 10, 2017 23:37
ccordoba12 added a commit that referenced this pull request Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants