PR: Adjust calls to use has_filenames return value of None #5777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5776.
The code calling
has_filename
andis_file_opened
was sometimes checking for a None or False value usingif not index
. This allowed the code to skip index 0 as a valid value.I also added docstrings because I think it's confusing that a function called
has_filename
would return an integer and not a boolean. Additionally,is_file_opened
can return a boolean or an integer depending on the parameter value.