PR: Change default behavior of --show-console option #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecate --show-console - Add hide console cli parameter
ccordoba12
reviewed
Nov 1, 2017
bootstrap.py
Outdated
| print("0x. Enforcing parent console (Windows only)") | ||
| sys.argv.append("--show-console") # Windows only: show parent console | ||
| if options.show_console: | ||
| print("(Deprecated) --show console do nothing, now the default behavior " |
|
Nice! I left a minor comment, then I'll merge. |
ccordoba12
reviewed
Nov 2, 2017
| if options.show_console: | ||
| print("(Deprecated) --show console does nothing, now the default " | ||
| " behavior is to show the console, use --hide-console if you " | ||
| "want to hide it") |
There was a problem hiding this comment.
Where this print is printed? I'd say is not necessary...
There was a problem hiding this comment.
It's printed in the console where spyder --show-console is executed
There was a problem hiding this comment.
Ok, thanks for the clarification!
ccordoba12
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5495