PR: Fix ValueError when switching Python interpreters #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Nov 6, 2017
spyder/plugins/maininterpreter.py
Outdated
| if custom: | ||
| self.warn_python_compatibility(cust_pyexec) | ||
| if custom and not self.warn_python_compatibility(cust_pyexec): | ||
| self.pyexec_edit.setText(def_pyexec) |
There was a problem hiding this comment.
I think we should show the same warning as above before doing this, i.e.
You selected an invalid Python interpreter for the console so the previous ...
There was a problem hiding this comment.
python_executable_changed and python_executable_switched had very similar code, especially with the addition of this message. Instead of duplicating the message, I instead changed it to call python_executable_changed from python_executable_switched. I hope that's OK.
|
Thanks @csabella! This looks good to me, except for my minor comment. |
|
Hello @csabella! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on November 09, 2017 at 13:10 Hours UTC |
|
@csabella, please fix the pep8 issue here. |
ccordoba12
approved these changes
Nov 9, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5402.
In issue #5402, the call to sys.version_info was returning
b''instead ofb'3'. The ValueError was a result of calling int() on an empty bytes value. The change checks for this exception and treats it the same as the call toprograms.is_python_interpreter().I don't know why the subprocess call with the program name and -h option would work in
is_python_interpreter(), but the -c option call fromwarn_python_compatibilitywouldn't returning a valid value. The assumption made was that if the -c option doesn't work, then something else might be wrong with the interpreter, so it switches back to the default.