Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix typo in Solarized color schemes. #5584

Merged
merged 2 commits into from
Oct 27, 2017
Merged

PR: Fix typo in Solarized color schemes. #5584

merged 2 commits into from
Oct 27, 2017

Conversation

rlaverde
Copy link
Member

Fixes: #5578

@rlaverde
Fix typo in solarized themes.
0116884 
Was causing and error when loading the preferences after reseting them to defaults values.
@rlaverde rlaverde added this to the v3.2.5 milestone Oct 26, 2017
@rlaverde rlaverde self-assigned this Oct 26, 2017
@rlaverde rlaverde requested a review from ccordoba12 October 26, 2017 21:46
ccordoba12
ccordoba12 requested changes Oct 27, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to know the error was very simple to solve!

However, I think this needs a major bump in CONF_VERSION for changes to take effect in older installations.

@rlaverde rlaverde force-pushed the fix-typo-color-schemes-defaults branch from b54ed9b to e14bd34 Compare October 27, 2017 12:58
@rlaverde
Copy link
Member Author

However, I think this needs a major bump in CONF_VERSION for changes to take effect in older installations.

Yes, I agree, renaming is like deleting old configs, and adding new ones

@ccordoba12 ccordoba12 changed the title PR: Fix typo in solarized themes schemes. PR: Fix typo in Solarized color schemes. Oct 27, 2017
@ccordoba12 ccordoba12 merged commit 9f281f5 into spyder-ide:3.x Oct 27, 2017
ccordoba12 added a commit that referenced this pull request Oct 27, 2017
@ccordoba12
Merge from 3.x: PR #5584
a56333c 
Fixes #5578
@rlaverde rlaverde deleted the fix-typo-color-schemes-defaults branch October 27, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@rlaverde rlaverde

Labels
None yet
Projects
None yet
Milestone
v3.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@rlaverde @ccordoba12