Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add handling for RuntimeError while closing an IPython console instance. #5576

Merged
merged 1 commit into from
Oct 26, 2017
Merged

PR: Add handling for RuntimeError while closing an IPython console instance. #5576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions spyder/plugins/ipythonconsole.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,8 +1249,12 @@ def close_client(self, index=None, client=None, force=False):
if index is not None:
client = self.tabwidget.widget(index)

# Close client
client.stop_button_click_handler()
# Needed to handle a RuntimeError. See issue 5568.
try:
# Close client
client.stop_button_click_handler()
except RuntimeError:
pass

# Check if related clients or kernels are opened
# and eventually ask before closing them
Expand Down