Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add handling for OSError's when changing directories. #5340

Merged
merged 2 commits into from
Sep 29, 2017
Merged

PR: Add handling for OSError's when changing directories. #5340

merged 2 commits into from
Sep 29, 2017

Conversation

dalthviz
Copy link
Member

Fixes #5183

@dalthviz dalthviz added this to the v3.2.4 milestone Sep 27, 2017
@dalthviz dalthviz self-assigned this Sep 27, 2017
@dalthviz dalthviz requested a review from ccordoba12 September 27, 2017 01:48
rlaverde
rlaverde reviewed Sep 27, 2017
View reviewed changes
spyder/plugins/workingdirectory.py Outdated
FileNotFoundError = WindowsError
else:
FileNotFoundError = IOError
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is better to catch OSError that's available in python2 and python3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rlaverde. @dalthviz, please simplify this code and only catch OSError here.

@ccordoba12 ccordoba12 changed the title PR: Add handling for FileNotFoundError when changing directories. PR: Add handling for OSError's when changing directories. Sep 29, 2017
ccordoba12
ccordoba12 approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 308455f into spyder-ide:3.x Sep 29, 2017
ccordoba12 added a commit that referenced this pull request Sep 29, 2017
@ccordoba12
Merge from 3.x: PR #5340
5484c5d 
Fixes #5183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlaverde rlaverde rlaverde left review comments

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
component:File Explorer type:Bug
Projects
None yet
Milestone
v3.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dalthviz @ccordoba12 @rlaverde