Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Don't show errors when kernel_client is None #5246

Merged
merged 2 commits into from
Sep 15, 2017
Merged

PR: Don't show errors when kernel_client is None #5246

merged 2 commits into from
Sep 15, 2017

Conversation

ccordoba12
Copy link
Member

Fixes #5053.

kernel_client can be None if the console failed to started for whatever reason.

@ccordoba12 ccordoba12 added this to the v3.2.4 milestone Sep 15, 2017
@pep8speaks
Copy link

Hello @ccordoba12! Thanks for submitting the PR.

Line 296:80: E501 line too long (87 > 79 characters)

@ccordoba12
Copy link
Member Author

The error reported by Pep8speaks is a false positive.

@ccordoba12 ccordoba12 merged commit 1c1cb40 into spyder-ide:3.x Sep 15, 2017
@ccordoba12 ccordoba12 deleted the fix-kernel-client-none branch September 15, 2017 19:17
ccordoba12 added a commit that referenced this pull request Sep 15, 2017
@ccordoba12
Merge from 3.x: PR #5246
902cc75 
Fixes #5053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @pep8speaks