PR: Avoid KeyboardInterrupt to raise an error in waitingspinner #5129
Conversation
spyder/app/mainwindow.py
Outdated
| @@ -288,6 +288,7 @@ def signal_handler(signum, frame=None): | |||
| pass | |||
| else: | |||
| signal.signal(signal.SIGTERM, signal_handler) | |||
| signal.signal(signal.SIGINT, signal_handler) | |||
There was a problem hiding this comment.
It make possible to kill Spyder using Ctrl+C, without this change It will still raise the report error message box when pressing Ctrl+C (but with a different traceback)
There was a problem hiding this comment.
Please remove this. We need to discuss it in another PR.
There was a problem hiding this comment.
@ccordoba12 why? I think it is important for people to be able to quit spyder on the terminal using Ctrl+C
There was a problem hiding this comment.
When Spyder freezes for whatever reason, it's very useful to press Ctrl+C in the terminal and get the traceback of where it was freezed.
There was a problem hiding this comment.
But the users will continue reporting false positives (now random) of when they tried to close spyder with Ctrl+C
There was a problem hiding this comment.
But that only happens when users press Ctrl+C in a terminal, and I doubt there are many of them.
In any case, I think this needs more discussion and is not related to this PR. So please remove it and open a new PR with this change only.
c50e013 to
77115ea
Compare
|
@ccordoba12 I moved that changes to a new PR #5159 and let only waiting spinner changes in this PR |
|
Great! Thanks @rlaverde! |
…raceback when spyder freezes, see: spyder-ide#5129).
…raceback when spyder freezes, see: spyder-ide#5129).
Fixes: #5114