PR: Fix unblock comments

[timhoffm]

Fixes #4313.

[pep8speaks]

Hello @timhoffm! Thanks for updating the PR.

• In the file spyder/plugins/configdialog.py, following are the PEP8 issues :

Line 887:1: W293 blank line contains whitespace
Line 890:80: E501 line too long (80 > 79 characters)
Line 891:50: E251 unexpected spaces around keyword / parameter equals
Line 891:52: E251 unexpected spaces around keyword / parameter equals
Line 891:80: E501 line too long (83 > 79 characters)
Line 899:1: W293 blank line contains whitespace
Line 903:66: W291 trailing whitespace

Comment last updated on August 29, 2017 at 18:44 Hours UTC

[timhoffm]

The pep8 checker above moans about the line length. I would be reluctant to wrap in the above case.

Do you have a policy for the line length? I've noticed that most code sticks to ~80 chars, but there are some exceptions.

While we're at it, do you have a documented code style? I've not found anything on this.

[jnsebgosselin]

@ccordoba12 I've tested it locally and this is working as expected. Maybe this should be rebased to the 3.x branch since this is a bug fix?

Maybe a test should also be added to test this feature?

[ccordoba12]

Maybe this should be rebased to the 3.x branch since this is a bug fix?

Yes, I think so too. @timhoffm, please follow these instructions to perform the rebase:

https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md#changing-base-branch

Also, please fix the style issues reported by Pep8speaks.

[timhoffm]

@ccordoba12, I've fixed the pep8.

Any idea why AppVeyor sometimes hangs at the test spyder/plugins/tests/test_ipythonconsole.py::test_console_import_namespace? For the first commit 2.7 hung but 3.6 ran. Now, with no change but some extra line breaks 2.7 ran, but 3.6 hung. I suspect this is not related to my code.

[ccordoba12]

@timhoffm, the failure was unrelated to your work. Thanks a lot for your contribution!