PR: Send Spyder python path to introspection plugins #4962

rlaverde · 2017-08-14T23:31:28Z

Fixes: #4410

Supersedes #4915
Undo some changes of #4263

At the moment the spyder path is only used by jedi

pep8speaks · 2017-08-14T23:31:33Z

Hello @rlaverde! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 30, 2017 at 00:09 Hours UTC

ccordoba12 · 2017-08-15T02:18:38Z

spyder/utils/introspection/jedi_plugin.py

@@ -30,6 +30,8 @@
 except ImportError:
    jedi = None

+JEDI_010 = [int(i) for i in jedi.__version__.split('.')] >= [0, 10, 0]


We have programs.is_module_installed exactly for this :-)

ccordoba12 · 2017-08-15T02:22:28Z

spyder/app/tests/test_mainwindow.py

@@ -110,7 +111,7 @@ def main_window(request):
    # (it's faster and less memory consuming not to use it!)
    marker = request.node.get_marker('use_introspection')
    if marker:
-        os.environ['SPY_TEST_USE_INTROSPECTION'] = 'True'
+        os.environ['SPY_TEST_USE_INTROSPECTION'] = 'USE_INTROSPECTION'


Please change this to True. That could fix the failing test below.

ccordoba12 · 2017-08-23T14:44:35Z

The way to implement this for Rope is the following:

The project attribute of RopePlugin has a prefs sub-attribute, as can be seen here:

https://github.com/spyder-ide/spyder/blob/3.x/spyder/utils/introspection/rope_plugin.py#L74
You can set a property in prefs called python_path, which is a list of additional paths to perform code completion. I think the way to do this is
```
 self.project.prefs.set('python_path', ['path1', 'path2'])
```
but you need to test it to see if it's right.
The previous step needs to be done every time we call the get_completions method of RopePlugin.

ccordoba12 · 2017-08-23T14:51:16Z

spyder/app/tests/test_mainwindow.py

@@ -110,7 +111,7 @@ def main_window(request):
    # (it's faster and less memory consuming not to use it!)
    marker = request.node.get_marker('use_introspection')
    if marker:
-        os.environ['SPY_TEST_USE_INTROSPECTION'] = 'True'
+        os.environ['SPY_TEST_USE_INTROSPECTION'] = True


This needs to be 'True', not True.

ccordoba12 · 2017-08-23T21:00:43Z

@rlaverde, please remove @dalthviz test because is timing out. Instead, please add tests to test_rope_plugin.py and test_jedi_plugin.py that get completions of some test module placed in a temp directory.

rlaverde · 2017-08-24T14:05:16Z

please remove @dalthviz test because is timing out. Instead, please add tests to test_rope_plugin.py and test_jedi_plugin.py that get completions of some test module placed in a temp directory.

I was trying to fix it without success 😞 I'll also try to move it to an editor test, maybe loading the main window is what's causing it to timeout.

ccordoba12 · 2017-08-25T16:07:33Z

@rlaverde, I think that adding the test to test_rope_plugin.py and test_jedi_plugin.py is easier and simpler than testing completion in our widgets.

rlaverde · 2017-08-25T17:35:19Z

I think that adding the test to test_rope_plugin.py and test_jedi_plugin.py is easier and simpler than testing completion in our widgets.

Yes, I'll give a last try to the integration test and I'll do that (the test is running pretty well in my local configuration, I don't know way CI is failing 😞 )

andfoy · 2017-08-25T18:05:20Z

@rlaverde Have you tried to debug those tests via SSH on Travis (https://docs.travis-ci.com/user/running-build-in-debug-mode/) and RDP on AppVeyor (https://www.appveyor.com/docs/how-to/rdp-to-build-worker/)?

…ed in the process enviroment.

ccordoba12 · 2017-08-28T22:19:09Z

spyder/plugins/tests/test_editor_introspection.py

+    editor.introspector.plugin_manager.close()
+
+
+@pytest.mark.skipif(True, reason="This test fails too much in the CI :(")


Let's remove this condition and change the one below to

not JEDI_010 or os.environ.get('CI', False)

so we can run this test locally.

ccordoba12 · 2017-08-28T22:22:50Z

@dalthviz, @arman00 and @laikh, please help us to test this PR to see if it fixes the problem with code completion in the Editor when using projects.

Thanks for your help!

dalthviz · 2017-08-29T17:58:44Z

@ccordoba12 It works for me 👍 🎉 , I tested opening and closing projects and changing the PYTHONPATH.

arman00 · 2017-08-29T18:06:22Z

Unfortunately it doesn't work for me. After I cloned from github , I switched to the 3.x branch. Version is 3.2.2.dev0.

It works if I create a new project, but with my existing project which has different modules in different folders, it doesn't work. I add those folders into the PYTHONPATH.

dalthviz · 2017-08-29T18:30:54Z

Hi @arman00 to test this you need to checkout the @rlaverde branch introspection-python-path, did you do that?

arman00 · 2017-08-29T18:39:45Z

Oh I see... Didn't know that :)
I will do it as soon as I have the chance again
Thanks

dalthviz · 2017-08-29T18:50:31Z

Just in case, to test this you can clone the fork of @rlaverde and then checkout the corresponding branch.

goanpeca · 2017-08-29T18:54:26Z

You can do

$ git clone https://github.com/rlaverde/spyder.git
$ cd spyder
$ git checkout introspection-python-path
$ python bootstrap.py

laikh · 2017-08-30T15:49:06Z

Hi guys,

Finally managed to test your solution and am happy to report that this fixed the issue for me!! 👍
I tested it with version 3.2.0 as 3.2.1 seems to be still not available for anaconda.

Thanx a lot, looking forward to the next version!

sincerely,
Michael

arman00 · 2017-08-30T17:35:18Z

Yes it works for me, too!!
Thanks for the instructions to test this!

ccordoba12 · 2017-08-30T18:58:22Z

Great news!! Thanks a lot to you for helping us to test this :-)

Fixes #4410

rlaverde added this to the v3.2.2 milestone Aug 14, 2017

rlaverde self-assigned this Aug 14, 2017

rlaverde requested a review from ccordoba12 August 14, 2017 23:31

rlaverde force-pushed the introspection-python-path branch from 3efe697 to b23d8aa Compare August 15, 2017 00:06

ccordoba12 reviewed Aug 15, 2017

View reviewed changes

ccordoba12 reviewed Aug 23, 2017

View reviewed changes

rlaverde force-pushed the introspection-python-path branch from 85dafe8 to 1f3cd95 Compare August 23, 2017 15:30

rlaverde force-pushed the introspection-python-path branch 4 times, most recently from 9164e61 to a3ef289 Compare August 25, 2017 14:20

rlaverde force-pushed the introspection-python-path branch from dad09dc to 7698e01 Compare August 25, 2017 17:27

rlaverde force-pushed the introspection-python-path branch from 7698e01 to fc03f98 Compare August 25, 2017 20:45

rlaverde added 6 commits August 25, 2017 17:15

Send python_path to jedy.

bd59929

Undo changes of PR spyder-ide#4263 because the python path isn't sett…

f3fafbb

…ed in the process enviroment.

Remove test changing path in process enviroment.

c8535d6

Add test for manager setting/removing extra path.

142f0ec

Check jedi version using utils.programs.

13a6321

Send python path to rope plugin.

5707fd3

rlaverde force-pushed the introspection-python-path branch from fc03f98 to 9e775dc Compare August 25, 2017 22:21

rlaverde added 2 commits August 25, 2017 17:23

Test editor-introspection

cb1fd4a

Skip editor-introspection test.

35177fc

Add unit test for get completions with a custom path.

aa9ac51

rlaverde force-pushed the introspection-python-path branch from 9e775dc to aa9ac51 Compare August 25, 2017 22:24

rlaverde added 2 commits August 28, 2017 11:02

Fix error when filename is None in rope.

e9f944d

Some PEP8 fixes. [ci skip] [skip ci]

aa67113

rlaverde requested a review from ccordoba12 August 28, 2017 17:45

ccordoba12 reviewed Aug 28, 2017

View reviewed changes

ccordoba12 changed the title ~~PR: Send spyder path to Introspection plugins~~ PR: Send Spyder python path to introspection plugins Aug 28, 2017

Only skip instrospection editor test in the CI.

25a5c3b

rlaverde force-pushed the introspection-python-path branch from 53dfcec to 25a5c3b Compare August 30, 2017 00:09

ccordoba12 merged commit e5f2faa into spyder-ide:3.x Aug 31, 2017

ccordoba12 added a commit that referenced this pull request Aug 31, 2017

Merge from 3.x: PR #4962

bcd769f

Fixes #4410

rlaverde deleted the introspection-python-path branch August 31, 2017 11:43

jitseniesen mentioned this pull request Feb 13, 2018

test_completions_custom_path fails with jedi 0.9.0 (Spyder 3) #6447

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Send Spyder python path to introspection plugins #4962

PR: Send Spyder python path to introspection plugins #4962

rlaverde commented Aug 14, 2017 •

edited by ccordoba12

Loading

pep8speaks commented Aug 14, 2017 •

edited

Loading

ccordoba12 Aug 15, 2017

ccordoba12 Aug 15, 2017

ccordoba12 commented Aug 23, 2017

ccordoba12 Aug 23, 2017

ccordoba12 commented Aug 23, 2017

rlaverde commented Aug 24, 2017

ccordoba12 commented Aug 25, 2017

rlaverde commented Aug 25, 2017 •

edited

Loading

andfoy commented Aug 25, 2017

ccordoba12 Aug 28, 2017

ccordoba12 commented Aug 28, 2017

dalthviz commented Aug 29, 2017

arman00 commented Aug 29, 2017

dalthviz commented Aug 29, 2017

arman00 commented Aug 29, 2017

dalthviz commented Aug 29, 2017

goanpeca commented Aug 29, 2017 •

edited

Loading

laikh commented Aug 30, 2017

arman00 commented Aug 30, 2017

ccordoba12 commented Aug 30, 2017

		editor.introspector.plugin_manager.close()


		@pytest.mark.skipif(True, reason="This test fails too much in the CI :(")

PR: Send Spyder python path to introspection plugins #4962

PR: Send Spyder python path to introspection plugins #4962

Conversation

rlaverde commented Aug 14, 2017 • edited by ccordoba12 Loading

pep8speaks commented Aug 14, 2017 • edited Loading

Comment last updated on August 30, 2017 at 00:09 Hours UTC

ccordoba12 Aug 15, 2017

Choose a reason for hiding this comment

ccordoba12 Aug 15, 2017

Choose a reason for hiding this comment

ccordoba12 commented Aug 23, 2017

ccordoba12 Aug 23, 2017

Choose a reason for hiding this comment

ccordoba12 commented Aug 23, 2017

rlaverde commented Aug 24, 2017

ccordoba12 commented Aug 25, 2017

rlaverde commented Aug 25, 2017 • edited Loading

andfoy commented Aug 25, 2017

ccordoba12 Aug 28, 2017

Choose a reason for hiding this comment

ccordoba12 commented Aug 28, 2017

dalthviz commented Aug 29, 2017

arman00 commented Aug 29, 2017

dalthviz commented Aug 29, 2017

arman00 commented Aug 29, 2017

dalthviz commented Aug 29, 2017

goanpeca commented Aug 29, 2017 • edited Loading

laikh commented Aug 30, 2017

arman00 commented Aug 30, 2017

ccordoba12 commented Aug 30, 2017

rlaverde commented Aug 14, 2017 •

edited by ccordoba12

Loading

pep8speaks commented Aug 14, 2017 •

edited

Loading

rlaverde commented Aug 25, 2017 •

edited

Loading

goanpeca commented Aug 29, 2017 •

edited

Loading