Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Reduce row height in shortcut dialog #4961

Merged
merged 3 commits into from
Aug 16, 2017

Conversation

timhoffm
Copy link
Contributor

The rows of the shortcut table have unneccesarily large heights. This patch reduces the height to the minimal possible height, so that more entries are visible -> increased usability.

before:
2017-08-14 20_52_48-preferences

after:
2017-08-14 20_53_54-preferences_new

@ccordoba12 ccordoba12 changed the title Reduce row height in shortcut dialog PR: Reduce row height in shortcut dialog Aug 15, 2017
@ccordoba12 ccordoba12 added this to the v3.2.2 milestone Aug 15, 2017
@ccordoba12
Copy link
Member

Nice! Thanks a lot for this!

I'm only going to ask you to move this PR from master to our 3.x branch, following these instructions:

https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md#changing-base-branch

@timhoffm timhoffm changed the base branch from master to 3.x August 15, 2017 20:11
@andfoy andfoy requested review from blink1073 and removed request for blink1073 August 15, 2017 20:27
@timhoffm
Copy link
Contributor Author

I've rebased to 3.x. Is there anything else I should do?

@goanpeca
Copy link
Member

@timhoffm nope, looks good :-)

Merging @ccordoba12?

@ccordoba12
Copy link
Member

Yep. @timhoffm thanks a lot for your contribution!

@ccordoba12 ccordoba12 merged commit d49bcb2 into spyder-ide:3.x Aug 16, 2017
ccordoba12 added a commit that referenced this pull request Aug 16, 2017
@timhoffm timhoffm deleted the shortcut_table branch August 16, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants