Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Check that combobox text is not empty string before emiting valid signal #4928

Merged
merged 1 commit into from
Aug 10, 2017
Merged

PR: Check that combobox text is not empty string before emiting valid signal #4928

merged 1 commit into from
Aug 10, 2017

Conversation

rlaverde
Copy link
Member

@rlaverde rlaverde commented Aug 9, 2017

Fixes #4922

@rlaverde rlaverde added this to the v3.2.2 milestone Aug 9, 2017
@rlaverde rlaverde requested a review from ccordoba12 August 9, 2017 23:06
@rlaverde rlaverde changed the base branch from master to 3.x August 9, 2017 23:08
ccordoba12
ccordoba12 approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rlaverde!

@ccordoba12 ccordoba12 modified the milestones: v3.2.1, v3.2.2 Aug 10, 2017
@ccordoba12 ccordoba12 merged commit de1d6ac into spyder-ide:3.x Aug 10, 2017
ccordoba12 added a commit that referenced this pull request Aug 10, 2017
@ccordoba12
Merge from 3.x: PR #4928
bdc8eea 
Fixes #4922
@rlaverde rlaverde deleted the static-code-valid-filebox branch August 10, 2017 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rlaverde @ccordoba12