Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Prevent importing packages that raise SystemExit exceptions when verifying if an object is defined #4849

Merged
merged 1 commit into from
Jul 29, 2017
Merged

PR: Prevent importing packages that raise SystemExit exceptions when verifying if an object is defined #4849

merged 1 commit into from
Jul 29, 2017

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Jul 28, 2017

Fixes #4810

@andfoy andfoy added this to the v3.2.1 milestone Jul 28, 2017
@andfoy andfoy self-assigned this Jul 28, 2017
@andfoy andfoy requested a review from ccordoba12 July 28, 2017 22:30
@andfoy andfoy changed the title PR: Add SystemExit to module import exception tuple on documentation help extraction PR: Prevent help module to import packages that raise SystemExit exceptions Jul 28, 2017
ccordoba12
ccordoba12 approved these changes Jul 29, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @andfoy!

@ccordoba12 ccordoba12 changed the title PR: Prevent help module to import packages that raise SystemExit exceptions PR: Prevent importing packages that raise SystemExit exceptions when verifying if an object is defined Jul 29, 2017
@ccordoba12 ccordoba12 changed the base branch from master to 3.x July 29, 2017 17:29
@ccordoba12 ccordoba12 merged commit 75ef6ff into spyder-ide:3.x Jul 29, 2017
ccordoba12 added a commit that referenced this pull request Jul 29, 2017
@ccordoba12
Merge from 3.x: PR #4849
c14f7a0 
Fixes #4810
@andfoy andfoy deleted the help_import_crash_prevention branch June 14, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@andfoy andfoy

Labels
component:Help component:IPython Console
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@andfoy @ccordoba12