Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Merge pull request #1 from spyder-ide/master #4848

Closed
wants to merge 2 commits into from

Conversation

juejung
Copy link

@juejung juejung commented Jul 28, 2017

Update from upstream

Before submitting your pull request be sure that:

  1. You haven't touched any file in the spyder/defaults directory.
  • There is absolutely no need to touch those files.
  • If you want to add new configuration options, please go to
    spyder/config/main.py.
  1. You haven't eliminated unnecessary blank lines or spaces during your work.
    That makes our reviewing work harder and it could introduce unnecessary
    conflicts with other pull requests.
  2. You haven't added new icons to Spyder. Please leave decisions about what
    icons to use to us :)

Note: You can safely remove this text before submitting your work.

@ccordoba12
Copy link
Member

@juejung, do you need help to submit a pull request for Spyder?

Unfortunately, this pull request is empty...

@juejung
Copy link
Author

juejung commented Jul 29, 2017

@ccordoba12 my apologies. @rlaverde asked me to test the changes in #4846 which fixes #4841 and I must have pressed the wrong button in Github (I'm new to this). I can confirm that #4846 fixes the issue in #4841 which I originally raised in #4316.
This one, #4848, was just done by accident and can be deleted. Sorry again for any confusion.

@ccordoba12
Copy link
Member

Ok, no problem. Thanks for helping @rlaverde to test that his PR really fixes your problem.

@ccordoba12 ccordoba12 closed this Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants