-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Extend Find in Files to select other search directories #4822
Conversation
@ccordoba12 Does it look right? |
I like it, a lot! @jnsebgosselin, @avylove, what do you think? |
Questions:
|
In point 2. I meant, are those paths saved when Spyder is closed and open again? |
On a single session we're storing all paths as the user would like. However, between sessions, we're just storing the 15 most recent entries. |
Looks pretty good @andfoy 👍 |
That could cause problems. Please limit that to the 15 most recent paths too. |
@andfoy do we have a Are these options adjusted when a project is opened (selecting the search in current option project?) |
@goanpeca Yes, I forgot to show it on the preview GIF. The option is only enabled when a project is opened |
@andfoy This looks great and very intuitive. I like it. Good job. |
@andfoy Looks great! Good solution! |
@andfoy, this requires now a merge with 3.x to fix conflicts. |
@ccordoba12 I think this one is ready |
Fixes #4814
Preview