Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Extend Find in Files to select other search directories #4822

Merged
merged 6 commits into from
Aug 16, 2017

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Jul 27, 2017

Fixes #4814

Preview

peek 27-07-2017 17-05

@andfoy andfoy added this to the v3.2.1 milestone Jul 27, 2017
@andfoy andfoy self-assigned this Jul 27, 2017
@andfoy andfoy changed the title [WIP] Extend Find in Files to select other search directories PR: Extend Find in Files to select other search directories Jul 27, 2017
@andfoy
Copy link
Member Author

andfoy commented Jul 27, 2017

@ccordoba12 Does it look right?

@ccordoba12
Copy link
Member

I like it, a lot!

@jnsebgosselin, @avylove, what do you think?

@ccordoba12
Copy link
Member

Questions:

  1. How many paths are we saving in the drop-down menu?
  2. Are those paths saved among sessions?

@ccordoba12
Copy link
Member

In point 2. I meant, are those paths saved when Spyder is closed and open again?

@andfoy
Copy link
Member Author

andfoy commented Jul 28, 2017

On a single session we're storing all paths as the user would like. However, between sessions, we're just storing the 15 most recent entries.

@goanpeca
Copy link
Member

Looks pretty good @andfoy 👍

@ccordoba12
Copy link
Member

On a single session we're storing all paths as the user would like

That could cause problems. Please limit that to the 15 most recent paths too.

@goanpeca
Copy link
Member

goanpeca commented Jul 28, 2017

@andfoy do we have a search in current project option ?

Are these options adjusted when a project is opened (selecting the search in current option project?)

@andfoy
Copy link
Member Author

andfoy commented Jul 28, 2017

@goanpeca Yes, I forgot to show it on the preview GIF. The option is only enabled when a project is opened

@jnsebgosselin
Copy link
Member

@andfoy This looks great and very intuitive. I like it. Good job.

@avylove
Copy link
Contributor

avylove commented Jul 28, 2017

@andfoy Looks great! Good solution!

@ccordoba12 ccordoba12 modified the milestones: v3.2.1, v3.2.2 Jul 28, 2017
@ccordoba12
Copy link
Member

@andfoy, this requires now a merge with 3.x to fix conflicts.

@andfoy
Copy link
Member Author

andfoy commented Aug 15, 2017

@ccordoba12 I think this one is ready

@andfoy andfoy deleted the find_in_files_folder branch June 14, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants