PR: Add icon to MessageCheckBox while avoiding unclickable issue #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The icon is passed as argument when initiating the MessageCheckBox. Thus, `setIcon` is called before adding a custom checkbox to the MessageCheckBox layout, avoiding the unclickable update message box issue. - Also, self is passed as parent to the MessageCheckBox. This allows to have the Spyder icon to show correctly on the left side corner of the popup window in Window OS. - Finally, when adding the custom checkbox to the MessageCheckBox layout, the position where the widget is added depends if PyQt4 or PyQt5 is used in order to take into account changes in Qt framework between Qt4 and Qt5.
|
@dalthviz, please test that @jnsebgosselin contribution works in PyQt5 as expected. |
ccordoba12
reviewed
Jul 14, 2017
spyder/widgets/helperwidgets.py
Outdated
| @@ -71,8 +71,12 @@ def __init__(self, *args, **kwargs): | |||
| check_layout.addItem(QSpacerItem(size, size)) | |||
|
|
|||
| # Access the Layout of the MessageBox to add the Checkbox | |||
| from qtpy import PYQT5 | |||
There was a problem hiding this comment.
Please move this import to the top of the fie. There's no need to put it here.
- This was only needed for IPython 2, but we don't support that version anymore. - This was breaking displaying Dataframes as html tables in spyder-notebook.
|
It works for me with Qt 5.6.2 PyQt5 5.6, this a preview of the dialog:
You can click the OK button and the links too 👍 |
PR: Don't set pandas.core.common.in_qtconsole anymore
|
@jnsebgosselin, please move this PR on your locale fork to the |
- The icon is passed as argument when initiating the MessageCheckBox. Thus, `setIcon` is called before adding a custom checkbox to the MessageCheckBox layout, avoiding the unclickable update message box issue. - Also, self is passed as parent to the MessageCheckBox. This allows to have the Spyder icon to show correctly on the left side corner of the popup window in Window OS. - Finally, when adding the custom checkbox to the MessageCheckBox layout, the position where the widget is added depends if PyQt4 or PyQt5 is used in order to take into account changes in Qt framework between Qt4 and Qt5.
…lin/spyder into 3.1.x-messagecheckbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an icon to the MessageCheckBox while avoiding the unclickable update message issue in PyQt5 and preserving backward compatibility with PyQt4.
Please revised that this fix works correctly in PyQt5. I cannot install PyQt5 alongside PyQt4 without messing my installation on my current setup. Feel free to give me advice to improve the way I can contribute.