Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Avoid visible_blocks to be empty when first visible block is wrapped #4733

Merged
merged 1 commit into from
Jul 26, 2017
Merged

PR: Avoid visible_blocks to be empty when first visible block is wrapped #4733

merged 1 commit into from
Jul 26, 2017

Conversation

rlaverde
Copy link
Member

@rlaverde rlaverde commented Jul 11, 2017 •
edited
Loading

Fixes #3166

This was also causing the fold panel to be empty.

@rlaverde rlaverde self-assigned this Jul 11, 2017
@rlaverde rlaverde requested a review from ccordoba12 July 11, 2017 21:40
@rlaverde rlaverde modified the milestone: v3.2.1 Jul 11, 2017
@ccordoba12 ccordoba12 changed the title PR: Fix error, visible_blocks empty when first visible block is wrapped. PR: Avoid visible_blocks to be empty when first visible block is wrapped Jul 11, 2017
@ccordoba12
Copy link
Member

Thanks @rlaverde! Could we add a test for it?

@ccordoba12 ccordoba12 merged commit 3df0621 into spyder-ide:3.x Jul 26, 2017
ccordoba12 added a commit that referenced this pull request Jul 26, 2017
@ccordoba12
Merge from 3.x: PR #4733
472a5ad 
Fixes #3166
@rlaverde rlaverde deleted the fix-error-linenumbers-wrap-mode branch September 18, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@rlaverde rlaverde

Labels
None yet
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rlaverde @ccordoba12