PR: Add more file type icons to File Explorer

[andfoy]

Fixes #3825

---

Icons are based on font-awesome's file-*-o icons and they are selected based on the inferred MIME type of each file:

[ccordoba12]

Great work @andfoy! I just have one question. On systems other than Windows, I'd like to report the icon of the file a symlink points to. Is this covered in your PR?

@dalthviz, please test this PR and see if it works on Windows correctly.

[andfoy]

@ccordoba12 I'll check if the icons apply to symlinks, if not, then they will be added! :-)

[ccordoba12]

Thanks a lot @andfoy!

[andfoy]

@ccordoba12 Symlinks preserve parent's icon only if the name preserves the original extension, should I override this behaviour?

[ccordoba12]

No, let's leave things as they are for now as see what users say about this.

We're waiting for @dalthviz to see if this works well on Windows.

[dalthviz]

@ccordoba12 @andfoy as soon as I manage to fix my Windows installation I will test this 👍

[dalthviz]

@andfoy @ccordoba12 some of the icons changed 👍 :

but there is an error:

I think that instead of AudioFileIcon the correct key is SoundFileIcon

[ccordoba12]

Also, it's not detecting xlsx as Excel files, and probably the same happens for docx and pptx.

[andfoy]

Actually, it seems that mimetypes modules is not recognizing docx, xlsx and pptx document extensions:

[ccordoba12]

Then force the association using the file extension, please.

[ccordoba12]

@dalthviz, please run a final test for this one, please.

[dalthviz]

@andfoy @ccordoba12 testing this is not working, but it's just because a missing dot in the dic that has the MS Office extensions (i.e .xlsx, .docx, .pptx). Also in the line 151 the icon assigment should be something like icon = ima.icon(self.OFFICE_FILES[extension])

[ccordoba12]

@dalthviz, please give it another try (hopefully the last one :-)

[dalthviz]

@andfoy @ccordoba12 👍

[ccordoba12]

Thanks @andfoy for your work and @dalthviz for reviewing it!