Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add more regular code annotation types #4456

Merged
merged 1 commit into from
May 10, 2017
Merged

PR: Add more regular code annotation types #4456

merged 1 commit into from
May 10, 2017

Conversation

cvanwynsberghe
Copy link

@cvanwynsberghe cvanwynsberghe commented May 10, 2017

Fixes #4452


The PR corresponds to the #4452 issue. It adds code tags HACK, BUG, OPTIMIZE, !!!, ??? to the common TODO and FIXME.

To keep the most common ones, I did a compromise according to the pep8-350 and many forums/websites relating to this topic.

hopefully I PR-ed pushed pulled all correctly :)

@ccordoba12 ccordoba12 added this to the v3.2 milestone May 10, 2017
@ccordoba12
Copy link
Member

Cool!! Things look right, so this is going in.

Thanks a lot for your contribution. It'll be available in Spyder 3.2.

@ccordoba12 ccordoba12 changed the title Add more regular code annotation types - 2 PR: Add more regular code annotation types May 10, 2017
@ccordoba12 ccordoba12 merged commit 67857dd into spyder-ide:3.x May 10, 2017
ccordoba12 added a commit that referenced this pull request May 10, 2017
@afvincent
Copy link
Contributor

afvincent commented May 11, 2017

@cvanwynsberghe I wonder if this line shouldn't be updated to reflect the new annotations introduced by your PR? (I stumble upon it when looking at a translation file ^^)

Edit: you can add this other line too.

@cvanwynsberghe
Copy link
Author

@afvincent Thank you for your remark, there is a new PR #4465 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants