Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: More robust username query #4311

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Conversation

ghisvail
Copy link
Contributor

The current method for querying the username via the USER envvar is fragile and may yield to problems. This PR proposes to use the getpass module from the stdlib instead, which should be more robust according to the docs.

web-flow and others added 2 commits April 2, 2017 19:29
The current method for querying the username via the `USER` envvar
is fragile and may yield to
[problems](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859080).
This PR proposes to use the `getpass` module from the stdlib instead,
which should be more robust.
@ccordoba12 ccordoba12 changed the base branch from master to 3.1.x April 3, 2017 00:32
@ccordoba12 ccordoba12 added this to the v3.1.4 milestone Apr 3, 2017
@ccordoba12
Copy link
Member

Thanks @ghisvail, looks good! I moved your contribution to 3.1.x so we can merge it in 3.1.4

@ccordoba12 ccordoba12 changed the title More robust username query PR: More robust username query Apr 3, 2017
@ccordoba12 ccordoba12 merged commit 6096c39 into spyder-ide:3.1.x Apr 3, 2017
ccordoba12 added a commit that referenced this pull request Apr 3, 2017
ccordoba12 added a commit that referenced this pull request Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants