PR: Move all tests to be pytest's #4199
Conversation
|
Please remove all commits related to |
66a4117 to
2388b21
Compare
|
@dalthviz, is this ready? |
|
@ccordoba12 I think that there are some more tests to be moved in |
|
@dalthviz, please remove all real tests (i.e. the ones that contain That would be the last thing to do before merging this one. Great work, as always!! |
|
@dalthviz, is this one ready? |
|
@ccordoba12 yes I think so 👍 |
| def test_fallback_plugin(): | ||
| """Test the fallback plugin.""" | ||
| p = FallbackPlugin() | ||
| print(FALLBACK_PLUGIN_FILE) |
| get_preferred_submodules) | ||
| from spyder.py3compat import PY3 | ||
|
|
||
| def test_codeanalysis(): |
There was a problem hiding this comment.
Change this to test_modulecompletion
| if not len(args) == 2: | ||
| return | ||
| plugin = PluginServer(*args) | ||
| qtbot.addWidget(plugin) |
There was a problem hiding this comment.
plugin_server is not a Qt widget. Please fix this.
| # Local imports | ||
| from spyder.utils.introspection.utils import CodeInfo | ||
|
|
||
| def test_codeanalysis(): |
There was a problem hiding this comment.
Change this to test_codeinfo
|
|
||
| def test_dochelpers(): | ||
| """Test dochelpers.""" | ||
| class Test(object): |
There was a problem hiding this comment.
Please move this class out of the test definition
| 'in descending order.', | ||
| 'name': 'sorted'} | ||
| assert getargtxt(sorted) == None | ||
| assert isdefined('numpy.take', force_import=True) == True |
There was a problem hiding this comment.
There's no need to assert ... == True. You can change this simply to assert ...
| 'name': 'sorted'} | ||
| assert getargtxt(sorted) == None | ||
| assert isdefined('numpy.take', force_import=True) == True | ||
| assert isdefined('__import__') == True |
| assert getargtxt(sorted) == None | ||
| assert isdefined('numpy.take', force_import=True) == True | ||
| assert isdefined('__import__') == True | ||
| assert isdefined('.keys', force_import=True) == False |
There was a problem hiding this comment.
assert not ... and remove False
|
The failure in CircleCI is caused by me. Don't worry about it :-) |
| get_preferred_submodules) | ||
| from spyder.py3compat import PY3 | ||
|
|
||
| def test_codeanalysis(): |
There was a problem hiding this comment.
test_codeanalysis -> test_module_completion
|
Please merge with |
Fixes #3195