Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Pin Jedi to 0.9.0 #4104

Merged
merged 6 commits into from
Feb 4, 2017
Merged

PR: Pin Jedi to 0.9.0 #4104

merged 6 commits into from
Feb 4, 2017

Conversation

ccordoba12
Copy link
Member

I ran our tests with the new 0.10.0 version and several of them are failing.

Besides, our new completions for Numpy and Matplotlib are failing with that version too.

@ccordoba12 ccordoba12 added this to the v3.1.3 milestone Feb 4, 2017
@ccordoba12 ccordoba12 merged commit 0e08506 into spyder-ide:3.1.x Feb 4, 2017
@ccordoba12 ccordoba12 deleted the jedi-09 branch February 4, 2017 21:08
ccordoba12 added a commit that referenced this pull request Feb 4, 2017
@ghisvail
Copy link
Contributor

Debian Stretch will ship with jedi v0.10.0, how should we proceed?

@ccordoba12
Copy link
Member Author

We are aiming at being compatible with Jedi 0.10 in version 3.1.4, to be released in a month or so.

If the addition of Jedi 0.10 is imminent in Debian Stretch, then users will have to depend on Rope until 3.1.4 is out.

@ghisvail
Copy link
Contributor

If the addition of Jedi 0.10 is imminent in Debian Stretch

It is there already.

users will have to depend on Rope until 3.1.4 is out

Rope is Python 2 only on Debian (version 0.10.3). Upstream got reliable support for Python 3 only recently (version 0.10.4), unfortunately not in time for the freeze. How important are rope / jedi for spyder ?

@ccordoba12
Copy link
Member Author

How important are rope / jedi for spyder ?

They provide code completion for the Editor, so I'd say pretty important :-)

@ghisvail
Copy link
Contributor

I meant spyder actually works fine without any of rope / jedi installed right? Sure, it would be a missing feature (whose importance is relative), but the rest of the editor will remain perfectly usable am I correct?

Otherwise, how far are you from having compatibility with 0.10.0? Is that something which could be cherry-picked on top of 3.1.3?

@ccordoba12
Copy link
Member Author

Otherwise, how far are you from having compatibility with 0.10.0?

I found some problems with 0.10.0 that we either have report upstream as errors or fix in our side. So I don't know when we'll be compatible with 0.10.0.

And there's also PR #4121.

Is that something which could be cherry-picked on top of 3.1.3?

I'd think you can cherry-pick our changes, yep.

@ghisvail
Copy link
Contributor

So, the corresponding patch to PR #4121 would make spyder 3.1.3 work with jedi 0.10.0 or is there more to be done?

@ccordoba12
Copy link
Member Author

is there more to be done?

Yes, there is. Our test suite is not passing with 0.10.0 even after applying #4121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants