PR: Show the number of matches in the Find/Replace widget

[mariacamilarg]

It now looks like this:

---

Edit:
Fixes #4001.

[mariacamilarg]

I'm still having trouble to calculate the position of the current search because of how the find is done. If you could give me please some insight I would really appreciate it!

[goanpeca]

@mariacamilaremolinagutierrez what is this PR fixing (add the `Fixes #NNN to the PR description comment on the top)

[ccordoba12]

@dalthviz, please rebase and finish this one.

[pep8speaks]

Hello @mariacamilaremolinagutierrez! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 19, 2017 at 03:29 Hours UTC

[dalthviz]

@ccordoba12 this PR has an issue already created? I can't find it.
Preview:

With a match:

Without a match:

In a WebView:

[ccordoba12]

I saw an issue about it but I can't find it right now.

I like it! @goanpeca, what do you say?

[ccordoba12]

@dalthviz, a test is missing. Please add one.

[goanpeca]

I like it :-p, can't find the issue either, @dalthviz go ahead and create one?

[ccordoba12]

@dalthviz, in your screenshots there's too much space between the matches text and the previous/next buttons. Please fix that.

[ccordoba12]

I like @mariacamilaremolinagutierrez screenshots better :-)

[dalthviz]

Ok 👍 although I left that space for stuff like this:

To have a fixed size that doesn't make the search text box resize when the label is long.

[ccordoba12]

I think it's better to resize the search dialog.

@goanpeca?

[goanpeca]

I think it's better to resize the search dialog

👍

[ccordoba12]

@dalthviz, is this ready?

[dalthviz]

@ccordoba12 yep 👍

[ccordoba12]

Thanks @dalthviz!