PR: Add a way to handle font errors in QtAwesome #3886

dalthviz · 2016-12-24T18:51:58Z

Is important to know that for this to actually work this PR has to get a merge in the qtawesome project because of the FontError import.

dalthviz · 2016-12-24T19:28:26Z

A preview of the message dialog:

ccordoba12 · 2016-12-30T21:39:35Z

spyder/app/mainwindow.py

+    except FontError as fontError:
+        import traceback
+        traceback.print_exc(file=STDERR)
+        traceback.print_exc(file=open('spyder_crash.log', 'w'))


We don't need these three lines.

ccordoba12 · 2016-12-30T21:46:53Z

spyder/app/mainwindow.py

+                " eventually creating a new issue <a href=\"%s\">here</a>. "
+                "Your feedback will always be greatly appreciated."
+                "" % (fontError ,__project_fonts__, __project_url__,
+                      __forum_url__, __project_url__))


Please rephrase this text like this

Spyder can't load the <i>Spyder 3</i> icon theme. That's why it's going to fallback to the theme used in Spyder 2. For that, please close this window and start Spyder again.

and make it translatable.

And after this dialog, we need to add this line

CONF.set('main', 'icon_theme', 'spyder 2')

(but please test that my approach works correctly by removing the QtAwesome fonts in your computer and starting Spyder again).

Better message

Spyder was unable to load the <i>Spyder 3</i> icon theme. That's why it's going to fallback to the theme used in Spyder 2. For that, please close this window and start Spyder again.

ccordoba12 · 2016-12-30T21:59:02Z

@dalthviz, I added a commit to your branch to fix some Travis errors. Please don't forget to pick it up locally.

Still this is a bit tricky to merge because it depends on a new version of QtAwesome. I'm going to release QtAwesome 0.4 with your FontError fix, so @dalthviz you need to bump here too our package requirements to that version in all places we define them. And for that, please check how @rlaverde did it for Chardet in PR #3640.

goanpeca · 2016-12-30T22:01:11Z

@ccordoba12 regarding

...you need to bump here too our package requirements to that version in all places we define them.

I suggest we use a requirements.txt file (or more as needed) as a single entry point for modifying dependencies (we can rely on this file for all CI services and scripts). This will make the updating of dependencies less error prone. I implemented this for another project and it eases the pain :0)

ccordoba12 · 2016-12-30T22:09:02Z

I suggest we use a requirements.txt file

Three reasons i think this is not a good idea:

We need fine grained control for our dependencies. For example, in CircleCI we need to install qtconsole along with the right PyQt version separately from the rest of our deps.
We're still testing that our conda and pip packages pull the right dependencies on Travis and AppVeyor. And for that, we don't need a requirements file, just let the packages to pull the dependencies.
People still wants to know (in README and our docs) what our dependencies are. Again, we can't use a simple requirements file for that.

I know this process is still cumbersome, but that's why CI services are for: to test if we did things right :-)

goanpeca · 2016-12-30T22:17:23Z

Regarding the comments

1.) That is the exception and not the rule (in reality is just PyQt ad Python)
2.) So?
3.) Sure we can, we put a link to the file and comment out the dependencies we have to handle "manually" on CI, which is basically for now just PyQt

goanpeca · 2016-12-30T22:21:52Z

... reasons i think this is not a good idea:

If I had nickel for every time...

…s in package requirements to version 0.4 of qtawesome.

ccordoba12 · 2016-12-31T06:14:37Z

@dalthviz, please add the QtAwesome version we need now in README.md and docs/installation.rst as 0.4+.

@goanpeca, sometimes you're right and sometimes not. But you're prone to give me the task of finishing what you start, and I really (really) don't have time for that now. So I think we're going to continue with our awkward (but proven ;-) procedure. As I said before, it's not something we do everyday so I'm fine with it.

goanpeca · 2016-12-31T07:10:40Z

ccordoba12 · 2017-01-02T04:24:32Z

@dalthviz, please change QtAwesome version to 0.4.1. I had to do some changes in 0.4 to better detect this error.

ccordoba12 · 2017-01-03T00:07:17Z

spyder/app/mainwindow.py

@@ -145,6 +145,7 @@
                              PY3, qbytearray_to_str, configparser as cp)
 from spyder.utils import encoding, programs
 from spyder.utils import icon_manager as ima
+from qtawesome.iconic_font import FontError


Please move this import after the qtpy ones, i.e. after line 92

ccordoba12 · 2017-01-03T19:02:04Z

Ok, this is ready now. Thanks a lot @dalthviz for your work on this one. It's very important for 3.1 :-)

Fixes #3843

Added a message dialog to inform the way to handle corrupted font files.

6d6ee4e

dalthviz changed the title ~~PR: Added a message dialog to inform the way to handle corrupted font files.~~ PR: Add a message dialog to inform the way to handle corrupted font files. Dec 27, 2016

dalthviz changed the title ~~PR: Add a message dialog to inform the way to handle corrupted font files.~~ PR: Add a message dialog to inform the way to handle untrusted/corrupted font files. Dec 28, 2016

Testing: Fix errors in Travis

9633d96

ccordoba12 reviewed Dec 30, 2016

View reviewed changes

Changes in the message. Added fallback to spyder 2 icon theme. Change…

3a999a0

…s in package requirements to version 0.4 of qtawesome.

ccordoba12 added this to the v3.1 milestone Dec 31, 2016

Changes in the docs.

4e93a1a

ccordoba12 changed the title ~~PR: Add a message dialog to inform the way to handle untrusted/corrupted font files.~~ PR: Add a way to bypass errors in QtAwesome Dec 31, 2016

Changed version of qtawesome to 0.4.1.

1bca765

ccordoba12 reviewed Jan 3, 2017

View reviewed changes

FontError import statement relocated.

df10f41

ccordoba12 changed the title ~~PR: Add a way to bypass errors in QtAwesome~~ PR: Add a way to handle font errors in QtAwesome Jan 3, 2017

ccordoba12 closed this Jan 3, 2017

ccordoba12 reopened this Jan 3, 2017

Add a comment about FontError import from qtawesome

8c933f8

ccordoba12 merged commit 2ca128a into spyder-ide:3.x Jan 3, 2017

ccordoba12 added a commit that referenced this pull request Jan 3, 2017

Merge from 3.x: PR #3886

6380abe

Fixes #3843

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Add a way to handle font errors in QtAwesome #3886

PR: Add a way to handle font errors in QtAwesome #3886

dalthviz commented Dec 24, 2016

dalthviz commented Dec 24, 2016

ccordoba12 Dec 30, 2016

ccordoba12 Dec 30, 2016

ccordoba12 Dec 30, 2016

ccordoba12 Dec 30, 2016 •

edited

Loading

ccordoba12 commented Dec 30, 2016

goanpeca commented Dec 30, 2016 •

edited

Loading

ccordoba12 commented Dec 30, 2016

goanpeca commented Dec 30, 2016 •

edited

Loading

goanpeca commented Dec 30, 2016

ccordoba12 commented Dec 31, 2016

goanpeca commented Dec 31, 2016

ccordoba12 commented Jan 2, 2017

ccordoba12 Jan 3, 2017

ccordoba12 commented Jan 3, 2017

PR: Add a way to handle font errors in QtAwesome #3886

PR: Add a way to handle font errors in QtAwesome #3886

Conversation

dalthviz commented Dec 24, 2016

dalthviz commented Dec 24, 2016

ccordoba12 Dec 30, 2016

Choose a reason for hiding this comment

ccordoba12 Dec 30, 2016

Choose a reason for hiding this comment

ccordoba12 Dec 30, 2016

Choose a reason for hiding this comment

ccordoba12 Dec 30, 2016 • edited Loading

Choose a reason for hiding this comment

ccordoba12 commented Dec 30, 2016

goanpeca commented Dec 30, 2016 • edited Loading

ccordoba12 commented Dec 30, 2016

goanpeca commented Dec 30, 2016 • edited Loading

goanpeca commented Dec 30, 2016

ccordoba12 commented Dec 31, 2016

goanpeca commented Dec 31, 2016

ccordoba12 commented Jan 2, 2017

ccordoba12 Jan 3, 2017

Choose a reason for hiding this comment

ccordoba12 commented Jan 3, 2017

ccordoba12 Dec 30, 2016 •

edited

Loading

goanpeca commented Dec 30, 2016 •

edited

Loading

goanpeca commented Dec 30, 2016 •

edited

Loading