PR: Add option to "clear all" variables before running file #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please amend the last commit message with something like instead of I think it's clearer to have such a message for Spyder git history :-) |
ccordoba12
reviewed
Jan 5, 2017
| _("All user-defined variables will be removed." | ||
| "<br>Are you sure you want to reset the namespace?"), | ||
| QMessageBox.Yes | QMessageBox.No, | ||
| def reset_namespace(self, predefined=False): |
There was a problem hiding this comment.
Please change this to
def reset_namespace(self, force=False):
ccordoba12
reviewed
Jan 5, 2017
| if reply == QMessageBox.Yes: | ||
| if reply == QMessageBox.Yes: | ||
| self.execute("%reset -f") | ||
| else: | ||
| self.execute("%reset -f") |
There was a problem hiding this comment.
To avoid saving this line on every execution of runfile, please change this to
shellwidget = self.get_current_shellwidget()
if shellwidget is not None:
shellwidget.silent_execute("%reset -f")There was a problem hiding this comment.
Sorry, this just needs to be
self.silent_execute("%reset -f")(I thought this method was part of the IPyhon console plugin).
ccordoba12
reviewed
Jan 5, 2017
| sw = self.get_current_shellwidget() | ||
| if sw is not None: | ||
| if clear_variables: | ||
| sw.reset_namespace(True) |
There was a problem hiding this comment.
Please change this to
sw.reset_namespace(force=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2563