PR: Added management for toolbars in new Editor windows instances. #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A screenshot to illustrate the changes:
|
|
Nice, I like it a lot! Please merge with 3.x to fix the tests in CircleCI. This is a new service we integrated with the repo to run our tests faster and check for code style. |
|
@dalthviz, there are code style failures reported by Please take a look at https://circleci.com/gh/spyder-ide/spyder/20 to fix them :-) |
ccordoba12
reviewed
Dec 10, 2016
| toolbars_names = CONF.get('main', 'last_visible_toolbars', default=[]) | ||
| print(toolbars_names) | ||
| if toolbars_names: | ||
|
|
ccordoba12
reviewed
Dec 10, 2016
| dic[toolbar.objectName()] = toolbar | ||
| toolbar.toggleViewAction().setChecked(False) | ||
| toolbar.setVisible(False) | ||
| print(dic) |
ccordoba12
reviewed
Dec 10, 2016
| """Loads the last visible toolbars from the .ini file.""" | ||
|
|
||
| toolbars_names = CONF.get('main', 'last_visible_toolbars', default=[]) | ||
| print(toolbars_names) |
ccordoba12
reviewed
Dec 10, 2016
|
|
||
| def load_toolbars(self): | ||
| """Loads the last visible toolbars from the .ini file.""" | ||
|
|
ccordoba12
reviewed
Dec 10, 2016
| """Get the toolbars.""" | ||
| return self.toolbars | ||
|
|
||
| def add_actions_to_menu(self, menu_title, actions): |
There was a problem hiding this comment.
This method should be called add_toolbars_to_menu
ccordoba12
reviewed
Dec 12, 2016
| menus.append(menu) | ||
| self.menus.append(menu) | ||
|
|
||
| def get_menu(self, menu_title): |
There was a problem hiding this comment.
Please change the definition of this method to to get_toolbar(self, toolbar_name)
|
Thanks @dalthviz, this looks good now :-) |
ccordoba12
added a commit
that referenced
this pull request
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes first point of #3790