PR: Added validation to window/position config value saved in spyder.ini #3754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Nov 28, 2016
| current_width = screenShape.width() | ||
| current_height = screenShape.height() | ||
| if current_width < width or current_height < height: | ||
| value = self.get_default(section, option) |
There was a problem hiding this comment.
Although this is the right thing to do, this is not the right place. You need to find where this setting is applied (most probably in app/mainwindow.py) and use this validation there.
ccordoba12
reviewed
Dec 1, 2016
| # with the current screen. See issue 3748 | ||
| width = pos[0] | ||
| height = pos[1] | ||
| screenShape = QApplication.desktop().geometry() |
There was a problem hiding this comment.
Please change this variable's name to screen_shape.
|
Other than a minor comment, this looks good to me. Thanks @dalthviz! |
|
Good job, thanks @dalthviz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3748