PR: Fix View/Toolbars menu #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem was a missing validation to add QAction elements in the method add_actions in |
ccordoba12
reviewed
Nov 27, 2016
| if insert_before is None: | ||
| target.addAction(action) | ||
| else: | ||
| target.insertAction(insert_before, action) | ||
| elif isinstance(action, SpyderAction): | ||
| if isinstance(target, QMenu) or not isinstance(target, QToolBar): | ||
| action = action.no_icon_action |
There was a problem hiding this comment.
This can be made simpler by changing this block and removing the code you introduced above, like this:
elif isinstance(action, QAction):
if isinstance(action, SpyderAction):
if isinstance(target, QMenu) or not isinstance(target, QToolBar):
action = action.no_icon_action|
Thanks @dalthviz for looking into this one. I added a comment to simplify our code, but other than that, this is ready :-) |
|
Thanks @dalthviz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3746