Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fixed weird behavior of "Save as" #3685

Merged
merged 2 commits into from
Nov 21, 2016

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 12, 2016

Fixes #3678
Fixes #3026

Edit: Include reference to a related issue

@dalthviz
Copy link
Member Author

The problem was that when the Save As... dialog opens and closes, the refresh method of the editor triggers before creating the new file. Triggering the refresh method also triggers a validation of the state of the file (if has been removed, moved or if is offline) that causes the weird dialogs to appear if no file can be found.

@ccordoba12 ccordoba12 added this to the v3.1 milestone Nov 12, 2016
@@ -1318,6 +1318,7 @@ def save_as(self, index=None):
# Save the currently edited file
index = self.get_stack_index()
finfo = self.data[index]
finfo.newly_created = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add above this line mentioning why this change is necessary.

@ccordoba12 ccordoba12 changed the title PR: Fixed weird behavior of Save as... PR: Fixed weird behavior of "Save as" Nov 21, 2016
@ccordoba12 ccordoba12 merged commit 0343e40 into spyder-ide:3.x Nov 21, 2016
ccordoba12 added a commit that referenced this pull request Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants