Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add ciocheck linter formater tester #3604

Merged
merged 5 commits into from
Dec 8, 2016
Merged

PR: Add ciocheck linter formater tester #3604

merged 5 commits into from
Dec 8, 2016

Conversation

goanpeca
Copy link
Member

Fixes #3535

@goanpeca goanpeca added this to the v3.1 milestone Oct 26, 2016
@goanpeca goanpeca self-assigned this Oct 26, 2016
@goanpeca
Copy link
Member Author

goanpeca commented Oct 26, 2016

This is ready for travis at the moment and only when using conda, cause pypi is now super stupid and I have to make a new release cause I made a mistake on upload and now you cant reupload a file... so stupid.

Anyway @ccordoba12 , this should be enough anyway to get us going, right now we only check pep8, pydostyle, pylint, and enforce pep8 and pydocstyle only for commited lines compared with master (not perfect for PRs merged against 3.x but I need to figure this one out)

@ccordoba12
Copy link
Member

I made a mistake on upload and now you cant reupload a file... so stupid.

Yeah, PyPi doesn't have build numbers :-)

this should be enough anyway to get us going

Nice!! Let me release 3.0.2 first and I'll come back right away to this one.

@goanpeca goanpeca changed the title PR: WIP Add ciocheck linter formater tester PR: Add ciocheck linter formater tester Oct 27, 2016
@goanpeca
Copy link
Member Author

goanpeca commented Dec 1, 2016

@ccordoba12 please activate circleci builds

fi
- pip install coveralls

script:
- if [ "${USE_CONDA}" = "true" ]; then
ciocheck spyder;
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these changes. Let's leave ciocheck to work in CircleCI only.

@ccordoba12
Copy link
Member

After you undo the travis.yml changes, I'll merge this one and then #3298.

@ccordoba12
Copy link
Member

@goanpeca, I did the necessary changes myself :-)

@ccordoba12 ccordoba12 merged commit f991b27 into spyder-ide:3.x Dec 8, 2016
ccordoba12 added a commit that referenced this pull request Dec 8, 2016
@goanpeca goanpeca assigned goanpeca and unassigned goanpeca Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants