-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add ciocheck linter formater tester #3604
Conversation
This is ready for travis at the moment and only when using conda, cause pypi is now super stupid and I have to make a new release cause I made a mistake on upload and now you cant reupload a file... so stupid. Anyway @ccordoba12 , this should be enough anyway to get us going, right now we only check pep8, pydostyle, pylint, and enforce pep8 and pydocstyle only for commited lines compared with master (not perfect for PRs merged against 3.x but I need to figure this one out) |
Yeah, PyPi doesn't have build numbers :-)
Nice!! Let me release 3.0.2 first and I'll come back right away to this one. |
@ccordoba12 please activate circleci builds |
fi | ||
- pip install coveralls | ||
|
||
script: | ||
- if [ "${USE_CONDA}" = "true" ]; then | ||
ciocheck spyder; | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these changes. Let's leave ciocheck to work in CircleCI only.
After you undo the |
It'd be run only in CircleCI
@goanpeca, I did the necessary changes myself :-) |
Fixes #3535