PR: Change of the label in the dependencies dialog #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r restart Spyder to update dependencies
|
@ccordoba12 this is ready for review :) |
ccordoba12
reviewed
Oct 18, 2016
| @@ -145,7 +145,9 @@ def __init__(self, parent): | |||
| "them.<br><br>" | |||
| "<b>Note</b>: You can safely use Spyder " | |||
| "without the following modules installed: " | |||
| "<b>%s</b> and <b>%s</b>") | |||
| "<b>%s</b> and <b>%s</b>. Also note that new " | |||
There was a problem hiding this comment.
Great! I like a lot the wording you decided to use. Just a couple of comments:
-
Add a
Pleaseat the beginning of the note:Please also note that new .... -
Add this note in a new paragraph by adding a
<br><br>like this:"<b>%s</b> and <b>%s</b>.<br><br>" "Please also note that new ...."
That's all :-)
|
Thanks @dalthviz! |
|
You’re welcome @ccordoba12 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3522