PR: Add a Shortcuts Summary window #3464

rlaverde · 2016-09-27T17:26:15Z

Same as #3331 but to the 3.x branch, so It could be merged early

ccordoba12 · 2016-09-27T18:50:55Z

@rlaverde, let's have first the work to remove fixed_shortcut before merging this PR :-)

ccordoba12 · 2016-09-29T21:18:55Z

@rlaverde, could you rebase or merge this with the 3.x branch? It seems you started this work before 3.0 was released, and that's making Travis to fail :-)

goanpeca · 2016-10-26T17:02:57Z

@rlaverde could you paste a screenshot just for reference?

Is it finished otherwise?

rlaverde · 2016-10-26T17:41:07Z

@goanpeca This isn't ready, I'm planning to rewrite some of the logic to calculate the maximum amount of lines for column

jitseniesen · 2016-10-26T18:23:35Z

Sorry, I have been rather picky 😊

ccordoba12 · 2016-10-26T19:50:10Z

Besides, the removal of fixed shortcuts have to be merged first :-)

ccordoba12 · 2016-11-30T16:15:29Z

spyder/widgets/shortcuts.py

+MAX_FONT_SIZE = 16
+MIN_FONT_SIZE = 8
+
+class ShortCutsSummaryDialog(QDialog):


Please name this as ShortcutsSummaryDialog

ccordoba12 · 2016-11-30T16:17:19Z

@rlaverde, please finish this one this week. After PR #3498, all our shortcuts should appear in this dialog :-)

ccordoba12 · 2016-11-30T16:18:46Z

spyder/widgets/shortcuts.py

@@ -0,0 +1,147 @@
+# -*- coding: utf-8 -*-


Please name this file as shortcutssummary.py because just shortcuts is a bit vague :-)

ccordoba12 · 2016-11-30T22:08:16Z

Tests are failing when they run this line

python spyder/widgets/shortcutssummary.py

ccordoba12 · 2017-01-16T18:02:20Z

@rlaverde, please solve conflicts for this one and finish it by the end of the week.

rlaverde · 2017-05-09T22:18:29Z

I tried to dynamically update the dialog to avoid it to be bigger of the screen, but it didn't work, because the size of the layout isn't updated when adding elements :/

I leave the "smart" logic that try to calculate the best amount of elements by column, and added an QScrollArea to prevent that the window will be bigger than the screen

ccordoba12 · 2017-05-10T00:58:28Z

Please rebase on top of 3.x and post a screenshot of how things look now.

ccordoba12 · 2017-05-10T00:59:03Z

The rebase is needed to fix the failures in Circle and Travis.

…umn using screen size

- Fix misspelling Summary - Remove dlg.show() - Change spyderlib for spyder in Copyright comment - Remove TODO out of date - Add docstring - Remove unused parameters

…than the screen.

…tcuts in each column.

goanpeca · 2017-05-10T13:56:13Z

Screenshot???? @rlaverde

rlaverde · 2017-05-10T14:01:37Z

ccordoba12 · 2017-05-10T14:58:38Z

I like it, a lot!! But I don't know if showing this dialog to the full width of the screen is the best option.

@goanpeca, @jitseniesen, what do you think?

jitseniesen

Looks good to me. I say we merge this and then we refine how it looks later if necessary.

jitseniesen · 2017-05-10T15:16:43Z

But I don't know if showing this dialog to the full width of the screen is the best option.

Full width seems okay to me because the shortcuts won't fit otherwise. Unless we select and display only the "important" shortcuts.

I guess I would prefer it if it scrolled vertically instead of horizontally.

ccordoba12 · 2017-05-10T15:19:41Z

I guess I would prefer it if it scrolled vertically instead of horizontally.

Yep, me too, but I don't know how we could achieve this.

Ok, let's merge this because it's a great improvement. We can improve it later, as you said :-)

Fixes #3275

goanpeca · 2017-05-10T15:37:54Z

@rlaverde its Shortcut not ShortCut, why the camel casing?

ccordoba12 added this to the v3.1 milestone Sep 27, 2016

goanpeca assigned ccordoba12 and rlaverde Oct 26, 2016

goanpeca changed the title ~~Add Shortcuts summary window~~ PR: Add Shortcuts summary window Oct 26, 2016

ccordoba12 reviewed Nov 30, 2016

View reviewed changes

rlaverde force-pushed the shortcuts_summary branch from 68ee28e to 464de6b Compare November 30, 2016 22:20

ccordoba12 modified the milestones: v3.2, v3.1 Jan 5, 2017

goanpeca unassigned ccordoba12 Jan 16, 2017

ccordoba12 modified the milestones: v3.2, v3.3 Feb 14, 2017

rlaverde force-pushed the shortcuts_summary branch from 464de6b to fb7a256 Compare May 9, 2017 22:12

rlaverde requested a review from jitseniesen May 9, 2017 22:19

rlaverde added 8 commits May 10, 2017 08:45

Add shortcuts Summary Window

e19e591

Add menu item and shortcut for shortcuts summary

d6543b6

Shortcuts Summary: Calculate font_size and amount of elements per col…

60a8f98

…umn using screen size

Several Fixes:

7b92522

- Fix misspelling Summary - Remove dlg.show() - Change spyderlib for spyder in Copyright comment - Remove TODO out of date - Add docstring - Remove unused parameters

Rename shortcuts.py file to shortcutssummary.py

f2a1947

Fix little typo in ShortcutsSummaryDialog class name

aa61d8d

ShortcutsSummary: Initialize group variable to prevent possible errors

25df8bb

ShortcutsSummary: Use a ScrollArea to avoid the dialog to be greater …

eda8cfc

…than the screen.

rlaverde force-pushed the shortcuts_summary branch from fb7a256 to eda8cfc Compare May 10, 2017 13:46

ShortcutsSummary: Take titles in account for calculate amount of shor…

01a0510

…tcuts in each column.

ccordoba12 closed this May 10, 2017

ccordoba12 reopened this May 10, 2017

jitseniesen approved these changes May 10, 2017

View reviewed changes

ccordoba12 changed the title ~~PR: Add Shortcuts summary window~~ PR: Add a Shortcuts Summary window May 10, 2017

ccordoba12 merged commit 8ced72a into spyder-ide:3.x May 10, 2017

ccordoba12 added a commit that referenced this pull request May 10, 2017

Merge from 3.x: PR #3464

21b718b

Fixes #3275

rlaverde deleted the shortcuts_summary branch May 10, 2017 19:22

csabella mentioned this pull request Nov 19, 2017

Show a page in the Object Inspector with all available keyboad shortcuts #1463

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Add a Shortcuts Summary window #3464

PR: Add a Shortcuts Summary window #3464

rlaverde commented Sep 27, 2016 •

edited

Loading

ccordoba12 commented Sep 27, 2016

ccordoba12 commented Sep 29, 2016

goanpeca commented Oct 26, 2016

rlaverde commented Oct 26, 2016

jitseniesen commented Oct 26, 2016

ccordoba12 commented Oct 26, 2016

ccordoba12 Nov 30, 2016 •

edited

Loading

ccordoba12 commented Nov 30, 2016

ccordoba12 Nov 30, 2016

ccordoba12 commented Nov 30, 2016

ccordoba12 commented Jan 16, 2017

rlaverde commented May 9, 2017 •

edited

Loading

ccordoba12 commented May 10, 2017

ccordoba12 commented May 10, 2017

goanpeca commented May 10, 2017

rlaverde commented May 10, 2017

ccordoba12 commented May 10, 2017

jitseniesen left a comment

jitseniesen commented May 10, 2017

ccordoba12 commented May 10, 2017

goanpeca commented May 10, 2017

PR: Add a Shortcuts Summary window #3464

PR: Add a Shortcuts Summary window #3464

Conversation

rlaverde commented Sep 27, 2016 • edited Loading

ccordoba12 commented Sep 27, 2016

ccordoba12 commented Sep 29, 2016

goanpeca commented Oct 26, 2016

rlaverde commented Oct 26, 2016

jitseniesen commented Oct 26, 2016

ccordoba12 commented Oct 26, 2016

ccordoba12 Nov 30, 2016 • edited Loading

Choose a reason for hiding this comment

ccordoba12 commented Nov 30, 2016

ccordoba12 Nov 30, 2016

Choose a reason for hiding this comment

ccordoba12 commented Nov 30, 2016

ccordoba12 commented Jan 16, 2017

rlaverde commented May 9, 2017 • edited Loading

ccordoba12 commented May 10, 2017

ccordoba12 commented May 10, 2017

goanpeca commented May 10, 2017

rlaverde commented May 10, 2017

ccordoba12 commented May 10, 2017

jitseniesen left a comment

Choose a reason for hiding this comment

jitseniesen commented May 10, 2017

ccordoba12 commented May 10, 2017

goanpeca commented May 10, 2017

rlaverde commented Sep 27, 2016 •

edited

Loading

ccordoba12 Nov 30, 2016 •

edited

Loading

rlaverde commented May 9, 2017 •

edited

Loading