Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix tutorial images on Windows #3174

Merged
merged 1 commit into from
Jun 11, 2016

Conversation

sylvain-bougnoux
Copy link
Contributor

The path was incorrect (folder 'static' was doubled).

Now it works on win7, python2.7, sphinx 1.4.1.
It could be seen, eg in the section "Documentation string formatting" of the tutorial.

@sylvain-bougnoux
Copy link
Contributor Author

Would someone help me with this tiny PR (my 1st one)?
Each travis test fails within:

$ cd doc; make html linkcheck
make: *** No rule to make target `html'.  Stop.

I did not change anything down there. What is this make? there is no 'makefile'! It sounds like a travis command or an alias on sphinx-build? The doc directory only has some *.rst and config.py. What I am missing? This test in .travis.yml was just pushed recently (2 weeks ago) by @PierreRaybaut.

BTW 'python setup.py build_doc', as suggested in the installation guide, does not work either for me, it crashed with missing directory 'build/lib/spyderlib/doc'. Could this be related?

Sorry for the disturbance, just want to help, thanks

@Nodd
Copy link
Contributor

Nodd commented May 24, 2016

This is not your fault, it has already been noted here: #3120 (comment)
We should revert this one.

@sylvain-bougnoux sylvain-bougnoux changed the title Fix tutorial images PR: Fix tutorial images May 25, 2016
@sylvain-bougnoux
Copy link
Contributor Author

Good to know - bad luck.
How can I relaunch the tests on this one? I could not find it.
Maybe send a stupid commit (white space) or close the PR and reopen a new one?

@goanpeca
Copy link
Member

@sylvain-bougnoux if you can rebase or merge with the latest master, the problem should be fixed

@ccordoba12 ccordoba12 added this to the v3.0beta3 milestone May 25, 2016
@Nodd
Copy link
Contributor

Nodd commented May 30, 2016

Travis
The build segfaults on startup:
./continuous_integration/travis/run_test.sh: line 40: 2888 Segmentation fault (core dumped) spyder
I have no idea where it comes from.

Appveyor
Looks like pytest is not installed:

Traceback (most recent call last):
  File "C:\projects\spyder\spyderlib\utils\fixtures.py", line 16, in <module>
    import pytest
ImportError: No module named 'pytest'
Command exited with code 1

An one failure is from Miniconda, I guess that it's temporary (like a download error).

@ccordoba12 ccordoba12 modified the milestones: v3.0beta4, v3.0beta3 Jun 5, 2016
@ccordoba12
Copy link
Member

@sylvain-bougnoux, could you merge again with master to see if our tests pass this time? Thanks :-)

@ccordoba12 ccordoba12 modified the milestones: v3.0rc1, v3.0beta4 Jun 9, 2016
@ccordoba12
Copy link
Member

@sylvain-bougnoux, your pull request now contains several commits that are already present on master. I don't know how you got into that state, but I think the easiest solution is for you to open a new pull request again with your changes.

Sorry for the hassle :-)

…led).

Now it works on win7, python2.7 sphinx 1.4.1, it could be seen, eg in the section "Documentation string formatting" of the tutorial.
@sylvain-bougnoux
Copy link
Contributor Author

Hi carlos, I've fixed my git branch, the tests are still pending, they should be fine. You are right, what a mess for these trivial fixes :-).

@ccordoba12
Copy link
Member

@sylvain-bougnoux, thanks for fixing your branch. Everything looks good now, so merging :-)

@ccordoba12 ccordoba12 changed the title PR: Fix tutorial images PR: Fix tutorial images on Windows Jun 11, 2016
@ccordoba12 ccordoba12 merged commit ebb7ca7 into spyder-ide:master Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants