Add an option to set window title to the command line #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,5 +37,7 @@ def get_options(): | |||
| parser.add_option('--profile', action='store_true', default=False, | |||
| help="Profile mode (internal test, " | |||
| "not related with Python profiling)") | |||
| parser.add_option('--windowtitle', type=str, default=None, | |||
There was a problem hiding this comment.
Could add an hyphen between window and title? So this option should be
--window-title
|
Other than my minor comments, I think this is ready :-) |
|
Ok, code is updated with the suggestions. |
| @@ -439,6 +439,9 @@ def signal_handler(signum, frame=None): | |||
| sys.version_info[1]) | |||
| if DEBUG: | |||
| title += " [DEBUG MODE %d]" % DEBUG | |||
| if not options.window_title is None: | |||
There was a problem hiding this comment.
if options.window_title is not None: is more commonly used in python, because it looks like an english sentence.
There was a problem hiding this comment.
Ok, changed to code for this
|
@eendebakpt, thanks a lot for your contribution! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3129