Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Russian translation. Updated POT file #3072

Merged
merged 5 commits into from
Apr 11, 2016
Merged

Added Russian translation. Updated POT file #3072

merged 5 commits into from
Apr 11, 2016

Conversation

burrbull
Copy link
Contributor

I had updated spydelib.pot with xgettext.
Added russian translation (~ 85% of strings).

@ccordoba12
Copy link
Member

@burrbull, thanks a lot for your contribution. I have two questions for you:

  1. Do you plan to finish the translation? I mean, right now we're some three months away of releasing Spyder 3.0 (which will contain this translation) so there's plenty of time for you to finish it :-)
  2. Can we count on you to keep updating the translation in the future?

@burrbull
Copy link
Contributor Author

  1. I'll try.
  2. Difficult question. Maybe.
    I'd never translated programms and I haven't much experience in this work.

@ccordoba12
Copy link
Member

About 2.: The most difficult part is the first translation. After that, updating a translation is a matter of half an hour of your time per each of our releases. And we do a new release every two months or so.

However, if you're not committed to update this translation, I'm afraid I'd have to decline your work because none of us speak Russian and the translation can get outdated very easily after a couple of releases :-)

@burrbull
Copy link
Contributor Author

I understood.
I'll do all in my power.
If I have free time I'll make the Ukrainian too.

@goanpeca
Copy link
Member

Awesome 👍 thanks a lot for the help :-)

@goanpeca
Copy link
Member

I updated the translators section of the wiki.

https://github.com/spyder-ide/spyder/wiki/Dev:-Translations

@burrbull
Copy link
Contributor Author

How to update PR?

Update repository from original 26.03.16
@ccordoba12
Copy link
Member

You need to add more commits to your branch (in this case your master branch :-).

@burrbull
Copy link
Contributor Author

burrbull commented Apr 2, 2016

Reverse question. How to remove excess commits from PR?

@ccordoba12
Copy link
Member

@burrbull, given that you merged with master several times, you can't squash commits (that's how removing commits is called in git :-).

Please merge with master again to make our tests pass (I fixed them a couple of days ago).

@Qlogin
Copy link
Contributor

Qlogin commented Apr 11, 2016

@burrbull, I've reviewed your translations and correct some mistakes (misprints).
Also, I've made some suggestions for better understanding of translated sentences.
I hope it would be useful.
spyderlib.po.txt

@ccordoba12, I can help to keep updating Russian translation in the future, if @burrbull won't have enough time.

@ccordoba12
Copy link
Member

@Qlogin, thanks a lot for offering your help. Should I merge then so you can send us your improvements in another PR?

I really prefer that instead of me committing your changes directly to master, but I'll do what you prefer :-)

@goanpeca
Copy link
Member

@Qlogin thanks a bunch for the help. I keep the wiki updated with current translators, I hope you dont mind me adding you to the list.

Cheers

https://github.com/spyder-ide/spyder/wiki/Dev:-Translations

@Qlogin
Copy link
Contributor

Qlogin commented Apr 11, 2016

@ccordoba12, I thought that @burrbull can look at the changes, choose some (or all) and commit it in current PR. He has made the whole work. Some of my changes are just rewording.
But if you are ready to merge right now, I'll create another PR and ask Andrey to approve improvements (to avoid "edit war").

@ccordoba12
Copy link
Member

@Qlogin, I think a separate PR with your improvements is the best strategy (as I said :-). So I'm merging this PR.

@burrbull, thanks a lot for your contribution and for your interest in making Spyder available to a bigger audience!

@ccordoba12 ccordoba12 modified the milestones: v3.0beta3, v3.0beta4 Apr 11, 2016
@ccordoba12 ccordoba12 merged commit 0886336 into spyder-ide:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants