PR: Enable 'Save All' if there are files to be saved #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jitseniesen LGTM 👍 |
|
Yep, looks good to me too. Thanks for your contribution @jitseniesen! |
ccordoba12
added a commit
that referenced
this pull request
Jan 27, 2016
PR: Enable 'Save All' if there are files to be saved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment 'Save All' is enabled if editor stack 0 has more than one file open and if one of the files opened in editor stack 0 has been changed. However, the 'Save All' action saves all changed files in the current editor stack (not editor stack 0), with no condition on the number of files opened.
This change ensures that 'Save All' is enabled precisely when 'Save All' would do something, that is, when the current editor stack has a file that has been changed.