Use PyQt5 as default API

[flying-sheep]

i think i did this once.

you stated then that it wasn’t ready, but that’s been some time ago and there are now PyQt5 travis tests.

also 3.0 should really ship like that.

[goanpeca]

@flying-sheep, until there is an official qt5 package in anaconda, I do not think we are doing this.

[flying-sheep]

if the API can’t be found, it will fall back to PyQt4, so this change does nothing for people without PyQt5.

the only thing it does is preferring to use PyQt5 if available, which is something that all Qt software should do now.

[flying-sheep]

oh it actually doesn’t, i’ll have to reorder things!

[ccordoba12]

@goanpeca, I think beta3 is a good point to move to PyQt5 :-)

@flying-sheep, tests for Qt5 are failing in Travis. Please solve the failure.

[ccordoba12]

@flying-sheep, I think I fixed the Travis error in master, so please rebase or merge with master to trigger a new build.

However, I think your change breaks Spyder when both PyQt4 and PyQt5 are installed. Please check that in your side.

[flying-sheep]

ok, will do

[ccordoba12]

Now this breaks all our tests in Travis. I really don't know what happens...

[flying-sheep]

ok, i rebased onto master. everything works now for whatever reason.

/edit: with and without pyqt4 installed

[ccordoba12]

I think we should set PYQT5 = False here.

[ccordoba12]

IMHO, it's easier to read and understand.

[ccordoba12]

Except for the comment I've just made, I think this ready.

[flying-sheep]

fixed

[ccordoba12]

Ok, I think this is ready! Merging :-)

[flying-sheep]

great 😄