Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runfile argument parsing error by using shlex #2784

Merged
merged 4 commits into from
Nov 9, 2015

Conversation

kapinga
Copy link

@kapinga kapinga commented Oct 27, 2015

Changed sitecustomize.runfile() to parse arguments using shlex instead of string.split(). This allows users to run scripts with arguments containing escaped spaces in ipython.

Fixes #2010

@ccordoba12
Copy link
Member

I'm fixing the tests in Appveyor. The failure is unrelated to your work.

Please don't do more merges with master :-)

@ccordoba12
Copy link
Member

I think I fixed the errors in AppVeyor, so please merge again with master now :-)

@kapinga
Copy link
Author

kapinga commented Oct 28, 2015

Sorry about that. I did another merge with master, but won't do that to you in future commits.

@ccordoba12
Copy link
Member

@kapinga, don't worry about it, It's fine what you did. I just wanted to warn you so you wait me until I fixed our (irritating) AppVeyor issues :-)

We're very new in this business of continuous integration, so we are still fixing things here and there :-)

@ccordoba12 ccordoba12 changed the title Fixed #2010 (runfile argument parsing error) Fix runfile argument parsing error Oct 28, 2015
@ccordoba12
Copy link
Member

@kapinga, could you merge with master again so that your PR gets some fixes to Travis and Appveyor I pushed yersterday?

Thanks :-)

@kapinga
Copy link
Author

kapinga commented Nov 9, 2015

@ccordoba12 I merged with master again and everything seems to have checked out.

@ccordoba12
Copy link
Member

@kapinga, thanks a lot for your patience and for your contribution!

Merging because this seems very useful ;-)

@ccordoba12 ccordoba12 changed the title Fix runfile argument parsing error Fix runfile argument parsing error by using shlex Nov 9, 2015
ccordoba12 added a commit that referenced this pull request Nov 9, 2015
Fix runfile argument parsing error by using shlex
@ccordoba12 ccordoba12 merged commit 339315e into spyder-ide:master Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants