Improved copying and selection behaviour of array editor #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2015 19:35
If a whole solumn or row is selected in the array editor then copy the whole of that from the array, even if the data isn't completely loaded into the array editor
If the selection includes complete rows or columns, these are expanded to reach the new ends
|
Thanks a lot for this and for taking the time to improve on your previous idea. I'm very +1 to your contribution, and I'll try to review it during the weekend :-) |
| # so we can treat it as intentional and copy the whole thing | ||
| col_max = self.model().total_cols-1 | ||
| if row_min == 0 and row_max == (self.model().rows_loaded-1): | ||
| row_max = self.model().total_rows-1 |
There was a problem hiding this comment.
I really like this, it's very clever and solves the select columns, rows and all content in a very elegant way!
There was a problem hiding this comment.
It's probably worth mentioning that it doesn't quite do the right thing if you try to select an usual shaped region (i.e. select some rows or columns, then hold down ctrl and add a few extra cells elsewhere). That's an issue with the original code (not my added code) and it would probably be quite hard to work out what to do with numpy there.
ccordoba12
added a commit
that referenced
this pull request
Oct 12, 2015
Improved copying and selection behaviour of array editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #2579 (so close that request if you're happy with this one).
The justification remains the same:
The reason for this change is that if you went to the array editor and used the top left square to select everything, it only selected the currently loaded data. For large arrays that was a subset of the whole thing (because extra data is fetched on demand). It wasn't obvious that it had done this unless you scrolled to check what it had selected, or copied the selection and found it was smaller than expected.
I've changed two things:
The advantage over the original pull request is that it no longer suddenly loads the whole array into the editor (which could use large amounts of memory)