Fix issues in Python3/PyQt5.5 #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,14 +93,14 @@ def clear_breakpoint(filename, lineno): | |||
| class EditorConfigPage(PluginConfigPage): | |||
| def get_name(self): | |||
| return _("Editor") | |||
|
|
|||
There was a problem hiding this comment.
Ok, first comment: please revert all this blank space changes :-) This makes merging other PRs really, really hard.
… Error in Python3/PyQt5.5
|
I have reverted the changes about spaces. |
| if event.delta() < 0: | ||
| self.zoom_out.emit() | ||
| elif event.delta() > 0: | ||
| self.zoom_in.emit() |
There was a problem hiding this comment.
Why this change? I say it because it's not related to QByteArray
There was a problem hiding this comment.
It's another bug related to PyQt5.5 . I fixed it and created a new pull request. I don't know why it is shown here.
Should I create a new branch for this?
There was a problem hiding this comment.
Don't worry, let's consolidate all PyQt5.5 issues here
This was referenced Aug 1, 2015
|
Thanks for your work @cy18! I'm going to merge this so we can release our first beta of Spyder 3.0 ;-) Please open new PRs if you find more issues with PyQt5.5 |
ccordoba12
added a commit
that referenced
this pull request
Aug 2, 2015
Fix issues in Python3/PyQt5.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2573
Fix issue that codes like QByteArray().fromHex(str(state)) raise Type Error in Python3/PyQt5.5
A Type Error is raised when codes like QByteArray().fromHex(str(state)) are called.
It seems the error is because in python3, str(state) will return an string while the QByteArray().fromHex expect an hex array.
I search the whole project of spyder and modifed codes like QByteArray().fromHex(str(state)) to QByteArray().fromHex(str(state).encode('utf-8')). The encode method of string will return a byte array in python3 and a string in python2.
I'm not familiar with PyQt and the source code of spyder. Feel free to reject my pull request if you have a better solution for this issue.